Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7r3] fix: ColorBar.draw_all() is replaced by figure.draw_without_rendering() #7209

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Sep 19, 2023

Aims at fixing the CI tests, broken by:

  • a matplotlib update from 3.5 to 3.8

    ************* Module DIRAC.Core.Utilities.Graphs.QualityMapGraph
    src/DIRAC/Core/Utilities/Graphs/QualityMapGraph.py:174:8: E1101: Instance of 'Colorbar' has no 'draw_all' member; maybe '_draw_all'? (no-member)

    According to their documentation: https://github.com/matplotlib/matplotlib/blob/main/doc/api/prev_api_changes/api_changes_3.8.0/removals.rst

    The filled attribute and the draw_all method of .Colorbar (instead of draw_all, use figure.draw_without_rendering).
    
  • import_resources.read_text()/path()

    ************* Module DIRAC.Core.Base.Client
    src/DIRAC/Core/Base/Client.py:170:23: E1101: Module 'importlib_resources' has no 'path' member (no-member)
    ************* Module DIRAC.FrameworkSystem.Client.ComponentInstaller
    src/DIRAC/FrameworkSystem/Client/ComponentInstaller.py:848:34: E1101: Module 'importlib_resources' has no 'read_text' member (no-member)
    src/DIRAC/FrameworkSystem/Client/ComponentInstaller.py:2198:16: E1101: Module 'importlib_resources' has no 'read_text' member (no-member)
    src/DIRAC/FrameworkSystem/Client/ComponentInstaller.py:2298:28: E1101: Module 'importlib_resources' has no 'read_text' member (no-member)

    According to the documentation, they have been replaced such as:

BEGINRELEASENOTES
*Core
FIX: replace ColorBar.draw_all() with figure.draw_without_rendering()
FIX: replace import_resources deprecated functions
ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:rel-v8r0 Cherry pick this PR to rel-v8r0 after merge label Sep 19, 2023
@aldbr aldbr force-pushed the rel-v7r3_FIX_matplotlib-update branch 2 times, most recently from d89e90c to efc958e Compare September 19, 2023 12:29
@aldbr aldbr force-pushed the rel-v7r3_FIX_matplotlib-update branch from efc958e to 3ca9984 Compare September 19, 2023 12:50
@fstagni fstagni added the sweep:ignore Prevent sweeping from being ran for this PR label Sep 20, 2023
@aldbr aldbr mentioned this pull request Sep 20, 2023
@fstagni fstagni merged commit 5938d10 into DIRACGrid:rel-v7r3 Sep 27, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:rel-v8r0 Cherry pick this PR to rel-v8r0 after merge sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants