Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve incompressible media assert #157

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Improve incompressible media assert #157

merged 1 commit into from
Dec 5, 2023

Conversation

nieweber
Copy link
Contributor

@nieweber nieweber commented Dec 4, 2023

The assert condition was fixed to also take the choice of the Boolean density_derp_h_from_media into account.

Furthermore the assertionLevel from the DropOfCommons model was included.

Closes #149

@nieweber nieweber requested a review from tobolar December 4, 2023 14:23
@nieweber nieweber self-assigned this Dec 4, 2023
@github-actions github-actions bot added the p::Boundaries Concerns package Boundaries and Undirected.Boundaries label Dec 4, 2023
tobolar
tobolar approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me.

@nieweber nieweber merged commit c2bb062 into DLR-SR:main Dec 5, 2023
4 checks passed
@nieweber nieweber deleted the volumeModelAssert branch December 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobolar tobolar tobolar approved these changes

Assignees

@nieweber nieweber

Labels
p::Boundaries Concerns package Boundaries and Undirected.Boundaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"assert" Volume models
2 participants
@nieweber @tobolar