Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realize connection loops in diagram instead of text block #160

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented Jan 17, 2024

In several models, vectorized connections are realized in the equation section by for-loops like:

  for i in 1:n loop
    connect(...);
  end for;

For models implemented graphically, such connections can't be recognized - they are only visible in source code. But generally, mixing of graphical and textual implementation shall be omited.

This PR shows a possible solution to work only in the diagram layer. In DiscretizedCrossFlowHEX, the JunctionN element is added to realize such inner loops.

@tobolar tobolar requested a review from nieweber January 17, 2024 14:51
@github-actions github-actions bot added the p::HeatExchangers Concerns package HeatExchangers and Undirected.HeatExchangers label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p::HeatExchangers Concerns package HeatExchangers and Undirected.HeatExchangers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant