Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA fix & solhint & slither #45

Merged
merged 48 commits into from
Aug 30, 2024
Merged

ECDSA fix & solhint & slither #45

merged 48 commits into from
Aug 30, 2024

Conversation

SurfingNerd
Copy link
Collaborator

SurfingNerd and others added 30 commits August 14, 2024 18:20
@SurfingNerd
regression test for verifying a signature what could not be verifyed …
781f101 
…using the UI.

DMDcoin/diamond-dapp-claiming#3
@SurfingNerd
fixed readme badge location
cd9acc5
@SurfingNerd
fixed test function not called.
e8d3951
@SurfingNerd
experimential version using openzeppelin contracts
305c7c3
@SurfingNerd
working network: alpha3
e3dacec
@SurfingNerd
Merge pull request #2 from DMDcoin/main
c60cd74 
update of missed changes
@SurfingNerd
Merge branch 'i42-ECDSA-recovery-merge' into i42-ECDSA-recovery-continue
5697132
@SurfingNerd
renamed function: publicKeyToBitcoinAddress to publicKeyToDMDAddress
d4fa1a0
@SurfingNerd
regression spec definition
6ffc36e
@SurfingNerd
small testset as testdata for upcomming json tests.
547104a
@SurfingNerd
JSON support for testdata
984bead
@SurfingNerd
added JSON test data set fort claiming.
ea0673d 
Note:
There are 3 Sets now, only one got picked up to tests:
small.json => Working Tests
known_x_00.json => failing tests, X coordiante of public key starts with 00
known_y_00.json => failing tests: Y coordinate of public key starts with 00.

Those testsets were separated manually.
DMDcoin/diamond-dapp-claiming#3
@SurfingNerd
hardhat default network: local
5ded0cb
@SurfingNerd
debug support for runAndAddClaimTests
959baf7
@SurfingNerd
cryptoHelper fixes
e2f6998
@SurfingNerd
loggin x and y
814a65f
@SurfingNerd
reverted contract bak to Solidity build in ecrecover
41d71e5
@SurfingNerd
better logging
39a9367
@SurfingNerd
tests: no debug output by default
2253f74
@SurfingNerd
removed @openzeppelin/contracts again
c621645
@SurfingNerd
large test support and 1k testset.
0a1ba44
@SurfingNerd
removed constants
d23707e
@SurfingNerd
comments improvements.
b390cc6
@SurfingNerd
solhint integration + fixing of warnings.
b8e8c15
@SurfingNerd
github pipeline integration.
bc059ee
@SurfingNerd
shell.nix for slither
eaa4019
@SurfingNerd
solc push to 0.8.26
135baca
@SurfingNerd
integrated larger testset, testrun with github actions.
a476c73
@SurfingNerd
made large test series optional and disabled by default. to enable th…
a0ec34f 
…em `export CLAIMING_TEST_RUN_LARGE=1`
@SurfingNerd
first integration try of slither.
9509d0f
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@coveralls
Copy link

coveralls commented Aug 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10625105994

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 88.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/ClaimContract.sol 8 11 72.73%
Totals Coverage Status
Change from base Build 10389818334: -2.6%
Covered Lines: 100
Relevant Lines: 103
💛 - Coveralls

@SurfingNerd SurfingNerd merged commit f43d4ce into DMDcoin:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SurfingNerd @coveralls