Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused function _getCurrentValWithSelector #45

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions contracts/DiamondDao.sol
Original file line number Diff line number Diff line change
Expand Up @@ -575,25 +575,6 @@ contract DiamondDao is IDiamondDao, Initializable, ReentrancyGuardUpgradeable, V
return stakingHbbft.isPoolValid(stakingAddress);
}

/**
* @dev Retrieves the current value from a contract using the provided function selector.
* @param contractAddress The address of the contract to call.
* @param funcSelector The function selector to use for the call.
* @return The current value returned by the contract.
*/
function _getCurrentValWithSelector(address contractAddress, string memory funcSelector) private view returns(uint256) {
bytes memory selectorBytes = abi.encodeWithSelector(bytes4(keccak256(bytes(funcSelector))));

(bool success, bytes memory data) = contractAddress.staticcall(selectorBytes);
if (!success) revert ContractCallFailed(selectorBytes, contractAddress);

uint256 result;
assembly {
result := mload(add(data, 0x20))
}
return result;
}

/**
* @dev Extracts the function selector and value from the given call data.
* @param _data The call data to extract from.
Expand Down
Loading