Skip to content

Merge pull request #96 from dforsten/dforsten/hbbft_no_failure #107

Merge pull request #96 from dforsten/dforsten/hbbft_no_failure

Merge pull request #96 from dforsten/dforsten/hbbft_no_failure #107

Triggered via push January 29, 2024 22:22
Status Success
Total duration 7m 42s
Artifacts

check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

33 warnings
Check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check: crates/ethcore/src/engines/hbbft/contribution.rs#L45
variable does not need to be mutable
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L22
fields `staking_address`, `socket_addr`, and `public_key` are never read
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L310
method `disconnect_pending_validators` is never used
Check: crates/ethcore/src/client/test_client.rs#L425
missing documentation for a method
Check: crates/ethcore/src/spec/spec.rs#L1200
missing documentation for an associated function
Check
`ethcore` (lib) generated 5 warnings (run `cargo fix --lib -p ethcore` to apply 1 suggestion)
Check: bin/evmbin/src/main.rs#L339
field `cmd_stats` is never read
Check
`evmbin` (bin "openethereum-evm") generated 1 warning
Check
the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
Check: crates/ethcore/src/engines/hbbft/contribution.rs#L45
variable does not need to be mutable
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L22
fields `staking_address`, `socket_addr`, and `public_key` are never read
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L310
method `disconnect_pending_validators` is never used
Check
`ethcore` (lib) generated 3 warnings (run `cargo fix --lib -p ethcore` to apply 1 suggestion)
Check: bin/oe/account_utils.rs#L19
unused import: `crypto::publickey`
Check: bin/oe/account_utils.rs#L21
unused import: `H160`
Check
`diamond-node` (lib) generated 2 warnings (run `cargo fix --lib -p diamond-node` to apply 2 suggestions)
Check
the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
Check: crates/ethcore/src/engines/hbbft/contribution.rs#L45
variable does not need to be mutable
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L22
fields `staking_address`, `socket_addr`, and `public_key` are never read
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L310
method `disconnect_pending_validators` is never used
Check: crates/ethcore/src/client/test_client.rs#L425
missing documentation for a method
Check: crates/ethcore/src/spec/spec.rs#L1200
missing documentation for an associated function
Check
`ethcore` (lib) generated 5 warnings (run `cargo fix --lib -p ethcore` to apply 1 suggestion)
Check: bin/evmbin/src/main.rs#L339
field `cmd_stats` is never read
Check
`evmbin` (bin "openethereum-evm" test) generated 1 warning
Check: crates/db/memory-db/benches/bench.rs#L47
unnecessary trailing semicolon
Check
`memory-db` (bench "bench") generated 1 warning
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/