Merge pull request #109 from DMTF/Fix108

Fix108: Return error when unable to parse
DMTF · Jun 6, 2019 · 45a6253 · 45a6253
2 parents c5b25f5 + 6c0a646
commit 45a6253
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/include/redfishService.h b/include/redfishService.h
@@ -297,6 +297,9 @@ REDFISH_EXPORT void serviceDecRef(redfishService* service);
  */
 REDFISH_EXPORT void serviceDecRefAndWait(redfishService* service);
 
+/** There was an error parsing the returned payload **/
+#define REDFISH_ERROR_PARSING 0xFFFE
+
 /** Accept any type of response **/
 #define REDFISH_ACCEPT_ALL  0xFFFFFFFF
 /** Accept a JSON response **/

diff --git a/src/service.c b/src/service.c
@@ -428,6 +428,15 @@ static void rawCallbackWrapper(asyncHttpRequest* request, asyncHttpResponse* res
             success = true;
         }
         payload = getPayloadFromAsyncResponse(response, myContext->service);
+        if(payload == NULL)
+        {
+            success = false;
+            if(response->httpResponseCode == 200)
+            {
+                //Override with an error code indicating parsing issues.
+                response->httpResponseCode = REDFISH_ERROR_PARSING;
+            }
+        }
         myContext->callback(success, (unsigned short)response->httpResponseCode, payload, myContext->originalContext);
     }
     freeAsyncRequest(request);