Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error when checking number_of_ckids in cxl_tsp_validate_capability #394

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mxu9
Copy link
Contributor

@mxu9 mxu9 commented Nov 20, 2024

Fix #393

According to CXL Spec 3.1 Table 11-32 Get Target Capabilities Response (Sheet 3 of 3) Byte Offset (1Ch):
Number of CKIDs: Total number of CKIDs that the target supports.
Valid only if CKID-based Encryption is set in Memory Encryption Features
Supported. Shall be >=2 and < 2^13.

One of the condition shall be:
device_capabilities->number_of_ckids >= 0x2000

According to CXL Spec 3.1 Table 11-32 Get Target Capabilities Response
(Sheet 3 of 3) Byte Offset (1Ch):
  Number of CKIDs: Total number of CKIDs that the target supports.
  Valid only if CKID-based Encryption is set in Memory Encryption Features
  Supported. Shall be >=2 and < 2^13.

One of the condition shall be:
  device_capabilities->number_of_ckids >= 0x2000

Signed-off-by: Min M Xu <[email protected]>
@jyao1 jyao1 merged commit c91d405 into DMTF:main Nov 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking number_of_ckids is not correct in cxl_tsp_validate_capability
2 participants