Merge pull request #218 from DSM-PICK/209-add-exception

🔀 :: (PICK-209)add exception
DSM-PICK · Jul 8, 2024 · c39d22f · c39d22f
2 parents edb800f + f91f73a
commit c39d22f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/...m/exception/ClassroomNorFoundException.kt → ...m/exception/ClassroomNotFoundException.kt b/...m/exception/ClassroomNorFoundException.kt → ...m/exception/ClassroomNotFoundException.kt
@@ -3,6 +3,6 @@ package dsm.pick2024.domain.classroom.exception
 import dsm.pick2024.global.error.exception.ErrorCode
 import dsm.pick2024.global.error.exception.PickException
 
-object ClassroomNorFoundException : PickException(
+object ClassroomNotFoundException : PickException(
     ErrorCode.CLASSROOM_NOT_FOUND
 )
diff --git a/src/main/kotlin/dsm/pick2024/domain/classroom/service/ChangeClassroomStatusService.kt b/src/main/kotlin/dsm/pick2024/domain/classroom/service/ChangeClassroomStatusService.kt
@@ -7,7 +7,7 @@ import dsm.pick2024.domain.attendance.domain.Attendance
 import dsm.pick2024.domain.attendance.port.out.QueryAttendancePort
 import dsm.pick2024.domain.attendance.port.out.SaveAllPort
 import dsm.pick2024.domain.classroom.domain.Classroom
-import dsm.pick2024.domain.classroom.exception.ClassroomNorFoundException
+import dsm.pick2024.domain.classroom.exception.ClassroomNotFoundException
 import dsm.pick2024.domain.classroom.port.`in`.ChangeClassroomStatusUseCase
 import dsm.pick2024.domain.classroom.port.out.DeleteClassRoomPort
 import dsm.pick2024.domain.classroom.port.out.QueryClassroomPort
@@ -29,7 +29,7 @@ class ChangeClassroomStatusService(
     override fun changeClassroomStatus(request: ClassroomStatusRequest) {
         if (request.status == NO) {
             for (id in request.ids) {
-                val classroom = queryClassroomPort.findByUserId(id) ?: throw ClassroomNorFoundException
+                val classroom = queryClassroomPort.findByUserId(id) ?: throw ClassroomNotFoundException
                 deleteClassRoomPort.deleteByUserId(classroom.userId)
             }
             return
@@ -39,7 +39,7 @@ class ChangeClassroomStatusService(
         val updateAttendanceList = mutableListOf<Attendance>()
 
         request.ids.forEach { id ->
-            val classroom = queryClassroomPort.findByUserId(id) ?: throw ClassroomNorFoundException
+            val classroom = queryClassroomPort.findByUserId(id) ?: throw ClassroomNotFoundException
 
             val updatedClassroom = classroom.copy(status = OK)
             update.add(updatedClassroom)

diff --git a/src/main/kotlin/dsm/pick2024/domain/classroom/service/UserMoveClassroomQueryService.kt b/src/main/kotlin/dsm/pick2024/domain/classroom/service/UserMoveClassroomQueryService.kt
@@ -1,5 +1,6 @@
 package dsm.pick2024.domain.classroom.service
 
+import dsm.pick2024.domain.classroom.exception.ClassroomNotFoundException
 import dsm.pick2024.domain.classroom.port.`in`.QueryUserMoveClassroomUseCase
 import dsm.pick2024.domain.classroom.port.out.QueryClassroomPort
 import dsm.pick2024.domain.classroom.presentation.dto.response.UserMoveClassroomResponse
@@ -16,7 +17,7 @@ class UserMoveClassroomQueryService(
     override fun queryUserMoveClassroom(): UserMoveClassroomResponse {
         val user = userFacadeUseCase.currentUser()
         val move = queryClassroomPort.findOKClassroom(user.id)
-            ?: throw Exception()
+            ?: throw ClassroomNotFoundException
 
         return UserMoveClassroomResponse(move.userName, move.classroomName, move.startPeriod, move.endPeriod)
     }

diff --git a/src/main/kotlin/dsm/pick2024/domain/notice/service/QueryNoticeService.kt b/src/main/kotlin/dsm/pick2024/domain/notice/service/QueryNoticeService.kt
@@ -1,5 +1,6 @@
 package dsm.pick2024.domain.notice.service
 
+import dsm.pick2024.domain.notice.exception.NoticeNotFoundException
 import dsm.pick2024.domain.notice.port.`in`.QueryAllNoticeUseCase
 import dsm.pick2024.domain.notice.port.out.QueryNoticePort
 import dsm.pick2024.domain.notice.presentation.dto.response.QueryAllNoticeResponse
@@ -29,7 +30,7 @@ class QueryNoticeService(
 
     override fun queryAllNotice(noticeId: UUID): QueryAllNoticeResponse {
         val notice = queryNoticePort.findById(noticeId)
-            ?: throw RuntimeException() //예외만들기
+            ?: throw NoticeNotFoundException
 
         return QueryAllNoticeResponse(
             title = notice.title,

diff --git a/src/main/kotlin/dsm/pick2024/domain/schedule/service/ModifyScheduleService.kt b/src/main/kotlin/dsm/pick2024/domain/schedule/service/ModifyScheduleService.kt
@@ -1,5 +1,6 @@
 package dsm.pick2024.domain.schedule.service
 
+import dsm.pick2024.domain.schedule.exception.ScheduleNotFoundException
 import dsm.pick2024.domain.schedule.port.`in`.ModifyScheduleUseCase
 import dsm.pick2024.domain.schedule.port.out.QuerySchedulePort
 import dsm.pick2024.domain.schedule.port.out.SaveSchedulePort
@@ -16,7 +17,7 @@ class ModifyScheduleService(
     @Transactional
     override fun modifyModify(request: ModifyScheduleRequest) {
         val schedule = querySchedulePort.findById(request.id)
-            ?: throw RuntimeException("")
+            ?: throw ScheduleNotFoundException
 
         saveSchedulePort.save(
             schedule.copy(