Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added main link method on item component to use in thumbnails. #3951

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oscar-escire
Copy link
Contributor

References

Add references/links to any related issues or PRs. These may include:

Description

A optional param was added to ds-thumbnail component to allow open a link if a user clicks on the bitstream. Also if an item has a main bitstream, this link is used. If it does not have one assigned, it takes the first available bitstream of the item's ORIGINAL bundle

Instructions for Reviewers

List of changes in this PR:

  • added a optional link parameter to thumbnail component
  • added a method to get the link of the main bitstream or the first item bitstream on ItemComponent
  • Updated unit test which involve thumbnail Component or Item Component to fit new changes
  • Added unit test for getMainBitstream method on ItemComponent

To test this PR:

  1. Open an item with bitstream and thumbnail assigned
  2. Clicks on the thumbnail icon to open the link

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added improvement component: Item (Archived) Item display or editing ux User Experience related works labels Feb 4, 2025
@tdonohue tdonohue modified the milestone: 9.0 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Item (Archived) Item display or editing improvement ux User Experience related works
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

Accessibility or discoverability of bitstream download links
2 participants