-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Event rate CI #40
base: develop
Are you sure you want to change the base?
Conversation
…saved to setup environment
… [note this will fail the event rates test]
…ctions/runs/13034320907/job/36403599512 it appears that CVMFS was not connecting correctly causing splines to be corrupted
Did you check with the supported approach of reading root files from Pierre's question here: https://dunescience.slack.com/archives/C7Z6Z9BBP/p1738592239751639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the entire tests directory if you use the github workflow text comparison script that I use in NuOscillator: https://github.com/dbarrow257/NuOscillator/blob/01bee0dfcee824524b81147853faea6be4a77f65/.github/workflows/CIValidations2.yml#L100-L106
Then you don't need the Comparison.{cpp,h} stuff. We should also force event rate CI checks, not allow them to be skipable
@@ -0,0 +1,49 @@ | |||
add_custom_target(MaCh3DUNETests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the entire tests directory if you use the github workflow text comparison script that I use in NuOscillator: https://github.com/dbarrow257/NuOscillator/blob/01bee0dfcee824524b81147853faea6be4a77f65/.github/workflows/CIValidations2.yml#L100-L106
Then you don't need the Comparison.{cpp,h} stuff. We should also force event rate CI checks, not allow them to be skipable
Pull request description:
Adds in configurable event rate CI for beam events
Changes or fixes:
Known Issues:
It seems like there is an issue with CVMFS not correctly linking to the container resulting in the test having some inconsistencies when reading inputs. Waiting some time + re-running seems to fix this issue
Wiki link
https://github.com/DUNE/MaCh3_DUNE/wiki/MaCh3-DUNE-Testing-&-CI