Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Event rate CI #40

Open
wants to merge 65 commits into
base: develop
Choose a base branch
from

Conversation

henry-wallace-phys
Copy link
Contributor

@henry-wallace-phys henry-wallace-phys commented Jan 30, 2025

Pull request description:

Adds in configurable event rate CI for beam events

Changes or fixes:

  • Beam event rate CI added
  • Adds basic tests folder and configuration
  • Currently configured for just a single beam sample but can be initialised to run with everything

Known Issues:

It seems like there is an issue with CVMFS not correctly linking to the container resulting in the test having some inconsistencies when reading inputs. Waiting some time + re-running seems to fix this issue

Wiki link

https://github.com/DUNE/MaCh3_DUNE/wiki/MaCh3-DUNE-Testing-&-CI

Henry Wallace added 30 commits January 27, 2025 07:23
@henry-wallace-phys henry-wallace-phys changed the title Hwallace/feature/event rate bot Feat: Event rate CI Jan 30, 2025
@dbarrow257
Copy link
Member

dbarrow257 commented Feb 6, 2025

It seems like there is an issue with CVMFS not correctly linking to the container resulting in the test having some inconsistencies when reading inputs. Waiting some time + re-running seems to fix this issue

Did you check with the supported approach of reading root files from Pierre's question here: https://dunescience.slack.com/archives/C7Z6Z9BBP/p1738592239751639

Copy link
Member

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the entire tests directory if you use the github workflow text comparison script that I use in NuOscillator: https://github.com/dbarrow257/NuOscillator/blob/01bee0dfcee824524b81147853faea6be4a77f65/.github/workflows/CIValidations2.yml#L100-L106

Then you don't need the Comparison.{cpp,h} stuff. We should also force event rate CI checks, not allow them to be skipable

@@ -0,0 +1,49 @@
add_custom_target(MaCh3DUNETests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the entire tests directory if you use the github workflow text comparison script that I use in NuOscillator: https://github.com/dbarrow257/NuOscillator/blob/01bee0dfcee824524b81147853faea6be4a77f65/.github/workflows/CIValidations2.yml#L100-L106

Then you don't need the Comparison.{cpp,h} stuff. We should also force event rate CI checks, not allow them to be skipable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants