Fix ADC Nbit = 14 and elecGain = 7.8 in wirecell, new correct values

[emanuele-villa]

This is a new MR since the other one got accidentally merged (and then reverted) as it was not marked as draft.

See #131 for more context.

Following up on the discussion in #132, I added the reading of Nbit and elecGain from fcl in all params.jsonnet files.

The values in wirecell_dune.fcl should be correct for all detectors; I left untouched the protodunesp NBit value and the elecGain for all protodune and coldbox configs (since the value changed only in the middle of July). I would recommend to access the gain value through database, in some way.

I have not yet tested if the jsons are created correctly with wcsonnet, I'll try to do that between today and tomorrow (need to set up some script or I'll get crazy).

If you prefer to hold this until our meeting, it's ok.

[brettviren]

FYI, you can make this the only site that uses std.extVar("NBits") and then leave all the detector-specific params.jsonnet files to inherit this value.

[emanuele-villa]

For this I think I'd need to update all the includes from local base = import "pgrapher/common/params.jsonnet"; to local base = import "common/params.jsonnet"; (or the right dunereco path).
I thought it was better to remove all wire-cell-toolkit paths together in the restructuring rather than a piece now and the rest later. Do you think it is better to change the path of params.jsonnet now already?

[emanuele-villa]

I will use extVar there in any case, ready for whenever that file will start being used

[brettviren]

For this I think I'd need to update all the includes from local base = import "pgrapher/common/params.jsonnet"; to local base = import "common/params.jsonnet"; (or the right dunereco path).

Yes, exactly. I wrongly assumed that was already the case. Otherwise, a DUNE-specific common/params.jsonnet is vestigial.

In fact, let me step back and suggest to copy all the rest of WCT's pgrapher/common/ as well so it lands at dunereco/DUNEWireCell/common/. Then, any occurrence of import "pgrapher/common/<whatever> must be changed to be import "common/<whatever>.

The main motivation to put (almost) all Jsonnets in one DUNE tree is that it helps the human to have "everything" in one spot. OTOH, if DUNE keeps a dependency on WCT's pgrapher/common/ for some files then that human must search WIRECELL_PATH to find the dependencies. Not super hard, I admit, but it is just one more thing to mentally carry.

Secondarily, it allows DUNE's copy to deviate from WCT's in the future. WCT's common/ area has to be kept broadly generic in order to support all detectors. DUNE can, in principle, simplify its configuration once free from this requirement.

[emanuele-villa]

I changed all jsonnet files to read the resolution from fcl, because I'd leave the reading from params.jsonnet for the refactoring (it's pretty deep and I think also include paths have to be fixed a bit). I was unfortunately not able to test, we can talk about it in the call in a couple minutes.

[emanuele-villa]

You can see in the last commits that I've done what we discussed: read the Nbit and elecGain values from a standard value defined in dunecore (DUNE/dunecore#141), removed all references to pgrapher/ paths, reading resolution from common/params.jsonnet.

I expect there to be mistakes but I have not had time to test how jsonnet dumps the configurations now and check if they remained consistent. @HaiwangYu if you have time to do it, it's excellent. Otherwise, I can try to find time tomorrow so that it can go in this week's release.