Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRST solarcluster PRODUCER UPLOAD #136

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Conversation

mantheys
Copy link
Member

@mantheys mantheys commented Mar 6, 2025

This is a SolarCluster producer module. It also includes the definition of a new class for low energy analysis "LowECluster". A LowECluster is a 3D reconstructed cluster associated with matched recob::Clusters which have been produced "per-plane" following a standard clustering approach. The LowEClusters object is the minimum expression of reconstruction for a lowe analysis and will be the triggering component of a future LowEEvent which is a class combining a set of LowEClusters (main + adjacent), PDS Flash (SolarOpFlash) and possible associated lowe tracks and pandora objects.

@mantheys mantheys requested a review from lpaulucc March 6, 2025 18:51
@mantheys mantheys self-assigned this Mar 6, 2025
@aolivier23
Copy link
Contributor

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

@aolivier23
Copy link
Contributor

@mantheys would you rather I wait for @lpaulucc to review this and wait until next week or try to review it myself this week?

@mantheys
Copy link
Member Author

mantheys commented Mar 7, 2025

Hi @aolivier23 thanks for taking care of this. I would say the more reviews, the better; so feel free to take a look, but I would also like @lpaulucc to validate this. There is no need to merge this this week; it can wait. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants