The Melberting #400
Merged
The Melberting #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… others) trigger when they should again. Also cleans up the knockoff component and unit tests it. (#67720) At some point, someone did a find and replace over this file, and completely screwed up the signal for Knockdown(). This caused components that relied on it, like the Knockoff component, to work way less often. This PR fixes that. It also goes through and cleans up the Knockoff component. More consistent style guide stuff, minor improvements, better documentation. It also unit tests it.
* Fixes the frozen trait never being applied * Don't apply if we already have the trait * Check the target obj
Fixes tonic water causing dizziness
Fixes social anxiety having auto-capitalization
DaedalusDock-Services
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports more of @MrMelbert 's status effect PRs, this time mostly simple stuff. Hallucinations is going to be absolute agony.
Knockdownsignal being incorrect, making knock-off items (and others) trigger when they should again. Also cleans up the knockoff component and unit tests it. tgstation/tgstation#67720Changelog
🆑 MrMelbert
fix: Items getting knocked off (glasses and cigars), bad omens, and spaghetti falling from pockets should trigger on most knockdowns again like they used to.
code: Cleaned up the knockoff component a bit. Also unit tests it.
fix: Frozen stuff is now properly actually recognized as frozen and won't re-freeze.
fix: Tonic Water heals dizziness instead of causing it
fix: Fixes stuttered words with anxiety being capitalized
/:cl: