Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alpha = 1 colorMod #1548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix alpha = 1 colorMod #1548

wants to merge 1 commit into from

Conversation

VReaperV
Copy link
Contributor

No description provided.

@slipher
Copy link
Member

slipher commented Feb 10, 2025

What's an example of where this makes a difference?

@VReaperV
Copy link
Contributor Author

Any that don't use vertex-based rgbGen/alphaGen, since it's set to 32 here:

Daemon/src/engine/renderer/gl_shader.h

Line 3643 in 55bf481

colorModulate |= Util::ordinal( ColorModulate::ALPHA_ADD_ONE );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Renderer T-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VReaperV @slipher