Feedback from emscripten-core#21406. NFC (emscripten-core#21415)

Daft-Freak · Feb 23, 2024 · 96124ff · 96124ff
1 parent f302d4c
commit 96124ff
Show file tree

Hide file tree

Showing 16 changed files with 22 additions and 18 deletions.
diff --git a/src/library.js b/src/library.js
@@ -3555,9 +3555,8 @@ addToLibrary({
 
   $HandleAllocator: class {
     constructor() {
-      // TODO(sbc): Use class fields once we allow/enable es2022 in
-      // JavaScript input to acorn and closure.
-      // Reserve slot 0 so that 0 is always an invalid handle
+      // TODO(https://github.com/emscripten-core/emscripten/issues/21414):
+      // Use inline field declarations.
       this.allocated = [undefined];
       this.freelist = [];
     }

diff --git a/src/library_fs.js b/src/library_fs.js
@@ -99,10 +99,13 @@ FS.staticInit();` +
 
     FSStream: class {
       constructor() {
+        // TODO(https://github.com/emscripten-core/emscripten/issues/21414):
+        // Use inline field declarations.
         this.shared = {};
 #if USE_CLOSURE_COMPILER
+        // Closure compiler requires us to declare all properties in the
+        // constructor.
         this.node = null;
-        this.flags = 0;
 #endif
       }
       get object() {
@@ -1652,6 +1655,8 @@ FS.staticInit();` +
           this.lengthKnown = false;
           this.chunks = []; // Loaded chunks. Index is the chunk number
 #if USE_CLOSURE_COMPILER
+          // Closure compiler requires us to declare all properties in the
+          // constructor.
           this.getter = undefined;
           this._length = 0;
           this._chunkSize = 0;

diff --git a/test/other/metadce/test_metadce_cxx_ctors1.gzsize b/test/other/metadce/test_metadce_cxx_ctors1.gzsize
@@ -1 +1 @@
-9887
+9883
diff --git a/test/other/metadce/test_metadce_cxx_ctors1.jssize b/test/other/metadce/test_metadce_cxx_ctors1.jssize
@@ -1 +1 @@
-24323
+24310
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.gzsize b/test/other/metadce/test_metadce_cxx_ctors2.gzsize
@@ -1 +1 @@
-9870
+9866
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.jssize b/test/other/metadce/test_metadce_cxx_ctors2.jssize
@@ -1 +1 @@
-24291
+24278
diff --git a/test/other/metadce/test_metadce_cxx_except.gzsize b/test/other/metadce/test_metadce_cxx_except.gzsize
@@ -1 +1 @@
-10971
+10968
diff --git a/test/other/metadce/test_metadce_cxx_except.jssize b/test/other/metadce/test_metadce_cxx_except.jssize
@@ -1 +1 @@
-28195
+28182
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm.gzsize b/test/other/metadce/test_metadce_cxx_except_wasm.gzsize
@@ -1 +1 @@
-9854
+9850
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm.jssize b/test/other/metadce/test_metadce_cxx_except_wasm.jssize
@@ -1 +1 @@
-24217
+24204
diff --git a/test/other/metadce/test_metadce_cxx_mangle.gzsize b/test/other/metadce/test_metadce_cxx_mangle.gzsize
@@ -1 +1 @@
-10982
+10979
diff --git a/test/other/metadce/test_metadce_cxx_mangle.jssize b/test/other/metadce/test_metadce_cxx_mangle.jssize
@@ -1 +1 @@
-28196
+28183
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.gzsize b/test/other/metadce/test_metadce_cxx_noexcept.gzsize
@@ -1 +1 @@
-9887
+9883
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.jssize b/test/other/metadce/test_metadce_cxx_noexcept.jssize
@@ -1 +1 @@
-24323
+24310
diff --git a/test/other/metadce/test_metadce_files_js_fs.gzsize b/test/other/metadce/test_metadce_files_js_fs.gzsize
@@ -1 +1 @@
-7843
+7840
diff --git a/test/other/metadce/test_metadce_files_js_fs.jssize b/test/other/metadce/test_metadce_files_js_fs.jssize
@@ -1 +1 @@
-19352
+19339