Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code optimisation and reuse, and better way to store images. #6

Open
DanteWinters opened this issue Apr 23, 2023 · 0 comments
Open

Code optimisation and reuse, and better way to store images. #6

DanteWinters opened this issue Apr 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@DanteWinters
Copy link
Owner

The current state of the code is far from optimal or readable. Most of the code is copy-paste instead of implementing reusable code. Along with implementing reusable code, find a better way of store the images than directly in the html code.
@DanteWinters DanteWinters added the bug Something isn't working label Apr 23, 2023
This was referenced May 11, 2023
Merged
Merged
DanteWinters added a commit that referenced this issue Jun 15, 2023
@DanteWinters
Enhancements
8974e2b 
 - #6 A lot of the code is stored in functions for easy reuse and images are stored as base64 encoded text
 - #8 Card can be added as a custom repository, but it being added to HACS as a default is pending
 - #9 Grid image will become duller when grid is unavailable and a red icon is added next to the grid voltage text
 - #18 Last update time is added at the bottom left of the card.
@DanteWinters DanteWinters mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanteWinters