Card rework #12
Merged
Card rework #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reworking card entirely - Using base64 images - Building card to allow for some configs not to be used (solar and energy_allocations) - Dividing code into smaller functions - Code reuse
- Added arrows (dynamically added), but without animations - Arrows change direction based on flow - Each of the different components have their updates split into smaller functions
- Displaying all the elements that were shown previously are now displayed again.
This was
linked to
issues
May 11, 2023
Closed
DanteWinters
added a commit
that referenced
this pull request
May 11, 2023
* guybw: Added images for local (#11) * Added images for local access. * moved files around --------- Co-authored-by: guybw <[email protected]> * Issue 6: uploaded images to for the card instead of using base64 encoded images. - Also added images for different battery levels and updated the README with a reference * Card rework (#12) * Rework with base64 (WIP): - Reworking card entirely - Using base64 images - Building card to allow for some configs not to be used (solar and energy_allocations) - Dividing code into smaller functions - Code reuse * Rework with base64: - Added arrows (dynamically added), but without animations - Arrows change direction based on flow - Each of the different components have their updates split into smaller functions * Rework with base64: - Displaying all the elements that were shown previously are now displayed again. --------- Co-authored-by: guybw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the card with better practices: