Make tests #5
Open
Make tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkWeird
requested changes
Dec 24, 2019
| @Autowired | ||
| BLZServicePortType blzServicePortType; | ||
|
|
||
| @Override | ||
| public DetailsType getBank(String blz) { | ||
| return blzServicePortType.getBank(blz); | ||
| } | ||
| // @Override |
There was a problem hiding this comment.
Закомментированый код - мертвый код. Удалить
| @@ -6,4 +6,5 @@ | |||
| public interface BlzCodeService { | |||
|
|
|||
| DetailsType getBank(String blz); | |||
| // DetailsType getCalc(String calk); | |||
There was a problem hiding this comment.
Закоментированный код - мертвый код
| @@ -48,6 +48,13 @@ | |||
| <artifactId>sqlite-jdbc</artifactId> | |||
| <version>3.8.11.2</version> | |||
| </dependency> | |||
| <!-- https://mvnrepository.com/artifact/com.sun.xml.ws/jaxws-rt --> | |||
| <dependency> | |||
| public class CalcExampleTest extends SpringCalcTest{ | ||
| @Autowired | ||
| CalculatorSoap calculatorSoap; | ||
| @Test |
There was a problem hiding this comment.
Проблемы с отступами для аннотаций. в IDEA ctrl+alt+L
| import org.springframework.test.context.ContextConfiguration; | ||
| import org.springframework.test.context.testng.AbstractTestNGSpringContextTests; | ||
| @ContextConfiguration(locations ={"classpath:spring-context.xml"} ) | ||
| public class SpringCalcTest extends AbstractTestNGSpringContextTests { |
There was a problem hiding this comment.
не зачем создавать лишний "Base" класс
DarkWeird
requested changes
Dec 24, 2019
| @@ -5,6 +5,7 @@ | |||
| import me.darkweird.testing.service.BlzCodeService; | |||
| import org.springframework.beans.factory.annotation.Autowired; | |||
| import org.springframework.stereotype.Service; | |||
| import ru.Robar3.CalculatorSoap; | |||
DarkWeird
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 8 test.