Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformBootManager: handle Vboot EC errors #127

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

mkopec
Copy link
Member

@mkopec mkopec commented Apr 11, 2024

No description provided.

@mkopec mkopec requested review from macpijan and miczyg1 April 11, 2024 15:06
@mkopec mkopec self-assigned this Apr 11, 2024
@miczyg1
Copy link
Contributor

miczyg1 commented Apr 12, 2024

LGTM, I will leave the message formula to @macpijan

@mkopec
Copy link
Member Author

mkopec commented Apr 23, 2024

@macpijan ping

@macpijan
Copy link
Contributor

How about:

Warning

It appears that firmware update process of the Embedded Controller has failed.
It is likely due to the AC adapter was not present. Please connect the AC
adapter, and boot the device again. 

If the AC adapter is connected, and the message persists after a few attempts,
please report this problem via one of the Dasharo support channels: https://docs.dasharo.com/#support

You may continue to use your device, although you may experience some issues
related to EC features (such as fan control, or function keys) if the EC
firmware version is not in sync with the main firmware.

@pietrushnic @BeataZdunczyk any thoughts?

@pietrushnic
Copy link
Contributor

@macpijan, do you plan to add a support section on docs.dasharo.com? I don't feel like a decision-maker regarding UX in firmware; I'm too biased, and my opinion is forming based on community and customer feedback. The message looks ok to me. It is not scary, but if it is received correctly, we can probably only verify it in the field.

@BeataZdunczyk
Copy link
Member

How about:

LGTM @macpijan.

@macpijan macpijan merged commit 176c51d into dasharo May 23, 2024
2 of 3 checks passed
@macpijan macpijan deleted the ec_update_error branch May 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants