Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg/Library/CustomizedDisplayLib: Fix hotkey positioning #97

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Oct 18, 2023

No description provided.

@miczyg1 miczyg1 requested a review from mkopec October 18, 2023 10:25
@miczyg1
Copy link
Contributor Author

miczyg1 commented Oct 18, 2023

Before adding CrScreenshotDxe:
Screenshot from 2023-10-18 12-06-07
After adding CrScreenshotDxe:
Screenshot from 2023-10-18 12-27-51
After this PR:
Screenshot from 2023-10-18 12-24-44

@macpijan
Copy link
Contributor

macpijan commented Oct 18, 2023

@miczyg1 Could you just confirm if menu parsing still works correctly with this change?

You should use the specified branch, as this is still WIP.

Please provide log if you can, so we can see how the boot_mgr_menu looks like.

@macpijan macpijan self-requested a review October 18, 2023 10:33
@miczyg1
Copy link
Contributor Author

miczyg1 commented Oct 18, 2023

@miczyg1 Could you just confirm if menu parsing still works correctly with this change?

You should use the specified branch, as this is still WIP.

Please provide log if you can, so we can see how the boot_mgr_menu looks like.

@macpijan All green: https://paste.dasharo.com/?80dee294c20b74a8#9VBi4vqXwQuSbTNqSfT4EJJzr7nV73AthyNrkrk6VMoq (unfortunately GH does not accept HTML files...)

@miczyg1
Copy link
Contributor Author

miczyg1 commented Oct 18, 2023

But I can see that the checkpoint for obtaining menu construction is incorrect now: ${expected}='Esc=Exit'.
It should be F9 hotkey to prevent catching the hotkey help.

Note that not all submenus display the hotkeys. It depends on the current form of currently highlighted option

Copy link
Contributor

@macpijan macpijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miczyg1 miczyg1 merged commit dfa3aa0 into dasharo Oct 19, 2023
2 checks passed
@miczyg1 miczyg1 deleted the fix_hotkey_help branch October 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants