Improve line parser #294
Improve line parser #294
Conversation
|
I like this idea for improving performance, we have an issue where we need to lint very large CSVs and the current code can be slow to do so. What work is left to do on this PR -- or was it abandoned for some reason. I might try to pick it up if there is a clear path forward. |
There was a problem hiding this comment.
The project is using Github Action.
There was a problem hiding this comment.
Github Action has a matrix for compatibility that test many Ruby version and ActiveSupport.
FastCSV should be added to the gemspec that is the equivalent to a Gemfile for a library.
All changes in this file should be reverted.
| @@ -170,7 +163,7 @@ | |||
| expect(validator.valid?).to eql(true) | |||
| end | |||
|
|
|||
| it "checks for non rfc line breaks" do | |||
| xit "checks for non rfc line breaks" do | |||
There was a problem hiding this comment.
Obviously, disabling tests is not the way to go.
| expect(validator.warnings.size).to eql(1) | ||
| expect(validator.warnings.first.type).to eql(:duplicate_column_name) | ||
| expect(validator.warnings.first.category).to eql(:schema) |
There was a problem hiding this comment.
Obviously, removing tests is not the way to go either.
This PR fixes #
Changes proposed in this pull request: