Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing Issues #196, #192 and #205 #197

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Addressing Issues #196, #192 and #205 #197

merged 5 commits into from
Feb 10, 2021

Conversation

ngvtien
Copy link
Contributor

@ngvtien ngvtien commented Sep 3, 2020 •
edited
Loading

Fixing issue #196

Caching the command parameter metadata is only applicable for dbType.…
fb33c73 
…String but not for the others.

Adding more test cases raised by issue DataAction#196
@ngvtien ngvtien added this to the 0.19.2 milestone Sep 3, 2020
Fix bug SchemaTableBuilder to not skip valid table which partial addr…
c5e9bb4 
…ess issue # 188 by include the IsUnique as well as IsKey in the validation to determine hasKey

Address issue DataAction#192 for duplicate parameter name
Update test cases
@ngvtien ngvtien changed the title Addressing Issue #196 Addressing Issues #196, #192 Sep 5, 2020
@ngvtien ngvtien changed the title Addressing Issues #196, #192 Addressing Issues #196, #192 and #205 Feb 9, 2021
@ngvtien ngvtien linked an issue Feb 9, 2021 that may be closed by this pull request
Allow for a certificate validation callback, so users can just straight up override the default behavior if needed. #205
Closed
SSMKittel
SSMKittel reviewed Feb 10, 2021
View reviewed changes
src/AdoNetCore.AseClient/AseConnection.cs Outdated
/// <param name="chain">The chain of certificate authorities associated with the remote certificate.</param>
/// <param name="sslPolicyErrors">One or more errors associated with the remote certificate.</param>
/// <returns>A System.Boolean value that determines whether the specified certificate is accepted for authentication.</returns>
public delegate bool RemoteCertificateValidationCallback(object sender, X509Certificate certificate, X509Chain chain, SslPolicyErrors sslPolicyErrors);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Shouldn't it already exist under System.Net.Security?

Remove the need to have custom local RemoteCertificateValidationCallb…
42ca3f9 
…ack and use the microsoft version instead after address the depdency conflict in test project
@ngvtien ngvtien merged commit 997af4c into DataAction:master Feb 10, 2021
@ngvtien ngvtien linked an issue Feb 10, 2021 that may be closed by this pull request
Another issue with command reuse #196
Closed
@ngvtien ngvtien removed a link to an issue Feb 10, 2021
Allow for a certificate validation callback, so users can just straight up override the default behavior if needed. #205
Closed
This was linked to issues Feb 10, 2021
AseCommand/AseParameterCollection does not throw if parameters contains duplicate keys #192
Closed
Allow for a certificate validation callback, so users can just straight up override the default behavior if needed. #205
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSMKittel SSMKittel SSMKittel approved these changes

@formicas formicas Awaiting requested review from formicas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.2
2 participants
@ngvtien @SSMKittel