Automatic (de)serialization for bundles (#6821, PR #6931)

DataBiosphere · Feb 26, 2025 · 28313d5 · 28313d5
2 parents 6589a7f + 1a0f6fb
commit 28313d5
Show file tree

Hide file tree

Showing 16 changed files with 449 additions and 248 deletions.
diff --git a/scripts/can_bundle.py b/scripts/can_bundle.py
@@ -114,10 +114,13 @@ def plugin_for(catalog):
 
 
 def save_bundle(bundle: Bundle, output_dir: str) -> None:
-    path = os.path.join(output_dir,
-                        f'{bundle.uuid}.{bundle.canning_qualifier()}.json')
+    file_name = f'{bundle.uuid}.{bundle.canning_qualifier()}.json'
+    path = os.path.join(output_dir, file_name)
+    bundle_json = bundle.to_json()
+    # We can bundles without the FQID so that we can mock it during tests
+    bundle_json.pop('fqid')
     with write_file_atomically(path) as f:
-        json.dump(bundle.to_json(), f, indent=4)
+        json.dump(bundle_json, f, indent=4)
     log.info('Successfully wrote %s', path)