Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1191: Fully switch to new image location #1001

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Feb 14, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-1191

Summary

This PR depends on #1000 (done), https://github.com/broadinstitute/terra-helmfile/pull/6034 (done), and https://github.com/broadinstitute/terra-helmfile/pull/6036 (done) merging first. Once those are complete, we can switch over to only pushing images to the new DSP artifact registry.

It is verified that the deployment is now using the new image location:
Screenshot 2025-02-14 at 11 27 18 AM


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong force-pushed the gr-DT-1191-dsp-gar-pt-2 branch from d93f951 to e01ef86 Compare February 14, 2025 15:52
@rushtong rushtong marked this pull request as ready for review February 14, 2025 16:23
@rushtong rushtong requested a review from a team as a code owner February 14, 2025 16:23
@rushtong rushtong requested review from pshapiro4broad and snf2ye and removed request for a team February 14, 2025 16:23
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, this is basically just an mv dsp_ar_build.yaml build.yaml, correct?

@rushtong
Copy link
Contributor Author

looks good, this is basically just an mv dsp_ar_build.yaml build.yaml, correct?

Yes, exactly. I'll try to make future PRs more clearly reflect that.

@rushtong rushtong merged commit ec3e6d6 into develop Feb 14, 2025
12 checks passed
@rushtong rushtong deleted the gr-DT-1191-dsp-gar-pt-2 branch February 14, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants