Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1206: Bug fixes for support requests #2455

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Feb 4, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-1206

Summary

This PR handles a couple of overlooked bugs

  • Fix the return format the upload token to be a valid json object instead of a plain string
  • Handle the Zendesk error case of UnprocessableEntityException when a normally well-formed ticket object cannot be processed by Zendesk due to invalid data

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review February 5, 2025 14:05
@rushtong rushtong requested a review from a team as a code owner February 5, 2025 14:05
@rushtong rushtong requested review from s-rubenstein and fboulnois and removed request for a team February 5, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant