Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-346][risk=no] Updated linter to support typescript linting #2585

Merged
merged 3 commits into from
May 14, 2024

Conversation

sjkobori
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-346

Summary

Added support for Typescript linting. These changes have been extracted from: #2557

@sjkobori sjkobori requested a review from a team as a code owner May 14, 2024 08:46
@sjkobori sjkobori requested review from rushtong and fboulnois and removed request for a team May 14, 2024 08:46
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks 👍🏽 One minor nit inline.

.eslintrc Outdated
}
]
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: revert the removal of the newline

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below:

@sjkobori sjkobori requested a review from fboulnois May 14, 2024 20:31
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you 👍

@sjkobori sjkobori merged commit 798bb66 into develop May 14, 2024
9 checks passed
@sjkobori sjkobori deleted the DCJ-346-Update-duos-ui-typescript-linter branch May 14, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants