feat: use anchor tags for all header and footer links (#297) #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
commented
Feb 19, 2025
| @@ -69,18 +70,17 @@ export const NavigationMenuItems = ({ | |||
| ) : ( | |||
| <Fragment key={i}> | |||
| <MMenuItem | |||
| component={isClientSide ? Link : MLink} | |||
There was a problem hiding this comment.
Component will either be MuiLink for external links or Next's Link component for internal links.
frano-m
commented
Feb 19, 2025
| @@ -0,0 +1 @@ | |||
| export const NAVIGATION_TEST_ID = "navigation"; | |||
There was a problem hiding this comment.
Added a test id to the central header's navigation; for future use.
MillenniumFalconMechanic
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297.
relattribute for internal / external urls.targetattribute, if configured, otherwise remain as_self.MuiLinkand internal links use Next'sLinkcomponent.Test
Navigationis advisable, however the component itself will need refactoring to handle recursion all in one file rather than having a parent ↔ child import cycle.