Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-7] Artifactory publish GHAs set up JDK #142

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

okotsopoulos
Copy link
Contributor

@okotsopoulos okotsopoulos commented Apr 4, 2024

https://broadworkbench.atlassian.net/browse/DCJ-7

Stairway failed to publish to Artifactory following my merge of #139.

I was surprised, because I was able to run a dry run of this command locally without issues.

Turns out that we need to update our GHAs to set JDK 17 (we already do this in the build and test workload).

Verified: https://github.com/DataBiosphere/stairway/actions/runs/8560933780

Copy link

@rtitle rtitle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@okotsopoulos okotsopoulos marked this pull request as ready for review April 4, 2024 20:35
Copy link

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great detective work!

Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@okotsopoulos okotsopoulos merged commit 856c127 into develop Apr 4, 2024
3 checks passed
@okotsopoulos okotsopoulos deleted the okotsopo-DCJ-7-fix-artifactoryPublish branch April 4, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants