Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1122] Implement zizmor suggestions #184

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Jan 9, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-1122

Summary

  • Do not persist credentials if not needed
  • Use shell variable expansion instead of template expansion
  • Include mavenCentral in gradle build to fix build issues

@fboulnois fboulnois requested a review from a team as a code owner January 9, 2025 14:41
@fboulnois fboulnois requested review from rushtong and rjohanek and removed request for a team January 9, 2025 14:41
@fboulnois fboulnois changed the title [DT-1122] Implement zizmor [DT-1122] Implement zizmor suggestions Jan 9, 2025
Copy link

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍🏽

@fboulnois fboulnois merged commit 7ee0de1 into main Jan 10, 2025
12 checks passed
@fboulnois fboulnois deleted the fb-dt-1122-apply-zizmor-fixes branch January 10, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants