Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Use registerCleanupTask for visibilityState cleanup #3063

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Oct 9, 2024

Motivation

Use registerCleanupTask for visibilityState cleanup

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (fcc37e4) to head (aea89de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3063      +/-   ##
==========================================
- Coverage   93.66%   93.18%   -0.49%     
==========================================
  Files         275      275              
  Lines        7611     7611              
  Branches     1707     1707              
==========================================
- Hits         7129     7092      -37     
- Misses        482      519      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.95 KiB 160.95 KiB 0 B 0.00%
Logs 56.00 KiB 56.00 KiB 0 B 0.00%
Rum Slim 109.53 KiB 109.53 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.000
addaction 0.030 0.058 0.028
addtiming 0.001 0.002 0.001
adderror 0.031 0.043 0.013
startstopsessionreplayrecording 0.846 1.160 0.315
startview 0.924 1.340 0.416
logmessage 0.019 0.034 0.015
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.67 KiB 7.27 KiB -414 B
addaction 38.77 KiB 39.06 KiB 297 B
addtiming 6.05 KiB 6.97 KiB 948 B
adderror 42.53 KiB 45.01 KiB 2.48 KiB
startstopsessionreplayrecording 3.72 KiB 4.71 KiB 1013 B
startview 458.87 KiB 464.82 KiB 5.95 KiB
logmessage 39.88 KiB 39.21 KiB -695 B

🔗 RealWorld

@amortemousque amortemousque marked this pull request as ready for review October 10, 2024 09:40
@amortemousque amortemousque requested a review from a team as a code owner October 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants