-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network policies for admission controller feature #1515
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
- Coverage 48.69% 48.57% -0.13%
==========================================
Files 225 225
Lines 19903 19957 +54
==========================================
+ Hits 9692 9694 +2
- Misses 9702 9752 +50
- Partials 509 511 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
{ | ||
Ports: []cilium.PortProtocol{ | ||
{ | ||
Port: strconv.Itoa(v2alpha1.DefaultAdmissionControllerTargetPort), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we have some available possibility to change the port, but it doesnt seems to be the case. Service is created the same way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have DD_ADMISSION_CONTROLLER_PORT
in the agent but we don't have an option to set that in the operator. I can create a card for it
What does this PR do?
Add network policies for the admission controller feature
Motivation
#1490
https://datadoghq.atlassian.net/browse/CECO-1741
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
datadog-lib-python-init
. If not mutated successfully, there won't be an init containerChecklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label