Skip to content

Commit

Permalink
trying to fix docker compose in integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tyrcho committed Aug 16, 2024
1 parent ad0b27f commit 1f17198
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
16 changes: 11 additions & 5 deletions aws/logs_monitoring/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -526,11 +526,17 @@ Resources:
- SetReservedConcurrentExecutions
- !Ref ReservedConcurrency
- !Ref AWS::NoValue
VpcConfig: !If
- UseVPC
- SecurityGroupIds: !Ref VPCSecurityGroupIds
SubnetIds: !Ref VPCSubnetIds
- !Ref AWS::NoValue
VpcConfig:
Fn::If:
- UseVPC
- SecurityGroupIds: !Ref VPCSecurityGroupIds

Check warning on line 532 in aws/logs_monitoring/template.yaml

View workflow job for this annotation

GitHub Actions / build

W1030 '' is not a 'AWS::EC2::SecurityGroup.GroupId' when 'Ref' is resolved
SubnetIds: !Ref VPCSubnetIds
- Ref: AWS::NoValue
#VpcConfig: !If
#- UseVPC
#- SecurityGroupIds: !Ref VPCSecurityGroupIds
#SubnetIds: !Ref VPCSubnetIds
#- !Ref AWS::NoValue
ForwarderRole:
Type: AWS::IAM::Role
Properties:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ LOG_LEVEL=${LOG_LEVEL} \
SNAPSHOTS_DIR_NAME="./${SNAPSHOTS_DIR_NAME}" \
DD_FETCH_LAMBDA_TAGS=${DD_FETCH_LAMBDA_TAGS} \
DD_FETCH_STEP_FUNCTIONS_TAGS=${DD_FETCH_STEP_FUNCTIONS_TAGS} \
docker-compose up --build --abort-on-container-exit
docker compose up --build --abort-on-container-exit

if [ $ADDITIONAL_LAMBDA == true ]; then
echo "Waiting for external lambda logs..."
Expand Down

0 comments on commit 1f17198

Please sign in to comment.