Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSM] Add messaging.destination tag to spans so they show up in queue pages #5239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericfirth
Copy link
Contributor

@ericfirth ericfirth commented Feb 10, 2025

What does this PR do?

In order for kafka queues to show up on the Service catalog they need to be tagged with peer.messaging.destination across each tracer. This does this for the Node tracer

Motivation

mproved inferred services.

Plugin Checklist

Additional Notes

@ericfirth ericfirth requested review from a team as code owners February 10, 2025 18:18
Copy link

github-actions bot commented Feb 10, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.07%. Comparing base (872bac8) to head (526325d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
- Coverage   81.26%   80.07%   -1.20%     
==========================================
  Files         487      373     -114     
  Lines       21706    17541    -4165     
==========================================
- Hits        17640    14046    -3594     
+ Misses       4066     3495     -571     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 10, 2025

Datadog Report

Branch report: eric.firth/add-messaging-destination-tag-to-node
Commit report: e23c5ee
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 629 Passed, 0 Skipped, 16m 15.99s Total Time

@ericfirth ericfirth force-pushed the eric.firth/add-messaging-destination-tag-to-node branch from dc52d7d to bb345d2 Compare February 10, 2025 19:20
@pr-commenter
Copy link

pr-commenter bot commented Feb 10, 2025

Benchmarks

Benchmark execution time: 2025-02-12 18:59:59

Comparing candidate commit 526325d in PR branch eric.firth/add-messaging-destination-tag-to-node with baseline commit 872bac8 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 910 metrics, 21 unstable metrics.

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 execution_time [+287.376ms; +296.814ms] or [+5.942%; +6.137%]
  • 🟥 max_rss_usage [+83.127MB; +94.677MB] or [+15.689%; +17.869%]

@ericfirth ericfirth force-pushed the eric.firth/add-messaging-destination-tag-to-node branch from bb345d2 to 526325d Compare February 12, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant