Skip to content

Commit

Permalink
feat(llmobs): add error.type to llmobs spans (#8723)
Browse files Browse the repository at this point in the history
This PR adds `error.type` to LLMObs spans marked with error.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
Yun-Kim authored Mar 21, 2024
1 parent e40d29f commit 7cfc2f6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ddtrace/llmobs/_trace_processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ def _llmobs_span_event(self, span: Span) -> Dict[str, Any]:
if span.get_tag(OUTPUT_VALUE):
meta["output"]["value"] = span._meta.pop(OUTPUT_VALUE)
if span.error:
meta["error.message"] = span.get_tag(ERROR_MSG)
meta["error.stack"] = span.get_tag(ERROR_STACK)
meta[ERROR_MSG] = span.get_tag(ERROR_MSG)
meta[ERROR_STACK] = span.get_tag(ERROR_STACK)
meta[ERROR_TYPE] = span.get_tag(ERROR_TYPE)
if not meta["input"]:
meta.pop("input")
if not meta["output"]:
Expand Down
1 change: 1 addition & 0 deletions tests/llmobs/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ def _llmobs_base_span_event(
"metrics": {},
}
if error:
span_event["meta"]["error.type"] = error
span_event["meta"]["error.message"] = error_message
span_event["meta"]["error.stack"] = error_stack
return span_event

0 comments on commit 7cfc2f6

Please sign in to comment.