fix(llmobs): do not ignore global patch env vars (#11662)

Fixes #11639.

This PR fixes an issue where `LLMObs.enable()` ignored/overrode global
patch env vars including `DD_TRACE_<INTEGRATION>_ENABLED` and
`DD_PATCH_MODULES`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

ddtrace/llmobs/_llmobs.py

@@ -23,6 +23,7 @@
 from ddtrace.internal.telemetry import telemetry_writer
 from ddtrace.internal.telemetry.constants import TELEMETRY_APM_PRODUCT
 from ddtrace.internal.utils.formats import asbool
+from ddtrace.internal.utils.formats import parse_tags_str
 from ddtrace.llmobs._constants import ANNOTATIONS_CONTEXT_ID
 from ddtrace.llmobs._constants import INPUT_DOCUMENTS
 from ddtrace.llmobs._constants import INPUT_MESSAGES
@@ -347,8 +348,20 @@ def flush(cls) -> None:
 
     @staticmethod
     def _patch_integrations() -> None:
-        """Patch LLM integrations."""
-        patch(**{integration: True for integration in SUPPORTED_LLMOBS_INTEGRATIONS.values()})  # type: ignore[arg-type]
+        """
+        Patch LLM integrations. Ensure that we do not ignore DD_TRACE_<MODULE>_ENABLED or DD_PATCH_MODULES settings.
+        """
+        integrations_to_patch = {integration: True for integration in SUPPORTED_LLMOBS_INTEGRATIONS.values()}
+        for module, _ in integrations_to_patch.items():
+            env_var = "DD_TRACE_%s_ENABLED" % module.upper()
+            if env_var in os.environ:
+                integrations_to_patch[module] = asbool(os.environ[env_var])
+        dd_patch_modules = os.getenv("DD_PATCH_MODULES")
+        dd_patch_modules_to_str = parse_tags_str(dd_patch_modules)
+        integrations_to_patch.update(
+            {k: asbool(v) for k, v in dd_patch_modules_to_str.items() if k in SUPPORTED_LLMOBS_INTEGRATIONS.values()}
+        )
+        patch(**integrations_to_patch)  # type: ignore[arg-type]
         log.debug("Patched LLM integrations: %s", list(SUPPORTED_LLMOBS_INTEGRATIONS.values()))
 
     @classmethod

releasenotes/notes/fix-llmobs-do-not-ignore-global-patch-configs-a2adc4803f55b142.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    LLM Observability: This fix resolves an issue where ``LLMObs.enable()`` ignored global patch configurations, specifically
+     the ``DD_TRACE_<INTEGRATION>_ENABLED`` and ``DD_PATCH_MODULES`` environment variables.

tests/llmobs/test_llmobs_service.py

@@ -31,6 +31,7 @@
 from ddtrace.llmobs._constants import SPAN_KIND
 from ddtrace.llmobs._constants import SPAN_START_WHILE_DISABLED_WARNING
 from ddtrace.llmobs._constants import TAGS
+from ddtrace.llmobs._llmobs import SUPPORTED_LLMOBS_INTEGRATIONS
 from ddtrace.llmobs._llmobs import LLMObsTraceProcessor
 from ddtrace.llmobs.utils import Prompt
 from tests.llmobs._utils import _expected_llmobs_eval_metric_event
@@ -144,6 +145,65 @@ def test_service_enable_already_enabled(mock_logs):
         mock_logs.debug.assert_has_calls([mock.call("%s already enabled", "LLMObs")])
 
 
+@mock.patch("ddtrace.llmobs._llmobs.patch")
+def test_service_enable_patches_llmobs_integrations(mock_tracer_patch):
+    with override_global_config(dict(_dd_api_key="<not-a-real-api-key>", _llmobs_ml_app="<ml-app-name>")):
+        llmobs_service.enable()
+        mock_tracer_patch.assert_called_once()
+        kwargs = mock_tracer_patch.call_args[1]
+        for module in SUPPORTED_LLMOBS_INTEGRATIONS.values():
+            assert kwargs[module] is True
+        llmobs_service.disable()
+
+
+@mock.patch("ddtrace.llmobs._llmobs.patch")
+def test_service_enable_does_not_override_global_patch_modules(mock_tracer_patch, monkeypatch):
+    monkeypatch.setenv("DD_PATCH_MODULES", "openai:false")
+    with override_global_config(dict(_dd_api_key="<not-a-real-api-key>", _llmobs_ml_app="<ml-app-name>")):
+        llmobs_service.enable()
+        mock_tracer_patch.assert_called_once()
+        kwargs = mock_tracer_patch.call_args[1]
+        for module in SUPPORTED_LLMOBS_INTEGRATIONS.values():
+            if module == "openai":
+                assert kwargs[module] is False
+                continue
+            assert kwargs[module] is True
+        llmobs_service.disable()
+
+
+@mock.patch("ddtrace.llmobs._llmobs.patch")
+def test_service_enable_does_not_override_integration_enabled_env_vars(mock_tracer_patch, monkeypatch):
+    monkeypatch.setenv("DD_TRACE_OPENAI_ENABLED", "false")
+    with override_global_config(dict(_dd_api_key="<not-a-real-api-key>", _llmobs_ml_app="<ml-app-name>")):
+        llmobs_service.enable()
+        mock_tracer_patch.assert_called_once()
+        kwargs = mock_tracer_patch.call_args[1]
+        for module in SUPPORTED_LLMOBS_INTEGRATIONS.values():
+            if module == "openai":
+                assert kwargs[module] is False
+                continue
+            assert kwargs[module] is True
+        llmobs_service.disable()
+
+
+@mock.patch("ddtrace.llmobs._llmobs.patch")
+def test_service_enable_does_not_override_global_patch_config(mock_tracer_patch, monkeypatch):
+    """Test that _patch_integrations() ensures `DD_PATCH_MODULES` overrides `DD_TRACE_<MODULE>_ENABLED`."""
+    monkeypatch.setenv("DD_TRACE_OPENAI_ENABLED", "true")
+    monkeypatch.setenv("DD_TRACE_ANTHROPIC_ENABLED", "false")
+    monkeypatch.setenv("DD_PATCH_MODULES", "openai:false")
+    with override_global_config(dict(_dd_api_key="<not-a-real-api-key>", _llmobs_ml_app="<ml-app-name>")):
+        llmobs_service.enable()
+        mock_tracer_patch.assert_called_once()
+        kwargs = mock_tracer_patch.call_args[1]
+        for module in SUPPORTED_LLMOBS_INTEGRATIONS.values():
+            if module in ("openai", "anthropic"):
+                assert kwargs[module] is False
+                continue
+            assert kwargs[module] is True
+        llmobs_service.disable()
+
+
 def test_start_span_while_disabled_logs_warning(LLMObs, mock_logs):
     LLMObs.disable()
     _ = LLMObs.llm(model_name="test_model", name="test_llm_call", model_provider="test_provider")