Skip to content

Commit

Permalink
ci: set ulimit inside the testrunner instance (#9409)
Browse files Browse the repository at this point in the history
We set the size of core dumps to unlimited at runtime inside the
testrunner image instance to allow any failing tests with fatal error to
generate core dumps.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
P403n1x87 authored May 29, 2024
1 parent c7679df commit d4b9274
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/ddtest
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if [[ "${CIRCLECI}" = "true" ]]; then
--quiet-pull \
--rm \
testrunner \
bash -c "$FULL_CMD"
bash -c "ulimit -c unlimited || true && $FULL_CMD"
else
docker-compose run \
-e DD_TRACE_AGENT_URL \
Expand Down

0 comments on commit d4b9274

Please sign in to comment.