fix(openai): propagate asyncio.TimeoutErrors correctly when openai operation canceled [backport 2.10] #10320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 16cdd6a from #10265 to 2.10.
Fixes #10191
In the case of an
asyncio
future cancellation, we want to propagate that error up appropriately. What this looks like is theresponse
from the OpenAI function beingNone
, which does not conform to the typing from the OpenAI SDK (see original issue). If the result is everNone
, we don't pass that result to our shared generator to handle OpenAI responses, and instead let the error bubble up.Checklist
Reviewer Checklist