ci: test with Python 3.13 #10821

brettlangdon · 2024-09-26T14:08:10Z

This change adjusts CI and the library itself to work under Python 3.13. Any tests that failed under 3.13 are skipped on 3.13 for now and will be unskipped in a future change.

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions · 2024-09-26T14:08:39Z

CODEOWNERS have been resolved as:

.riot/requirements/102dfdd.txt                                          @DataDog/apm-python
.riot/requirements/104daf8.txt                                          @DataDog/apm-python
.riot/requirements/104f450.txt                                          @DataDog/apm-python
.riot/requirements/1053dce.txt                                          @DataDog/apm-python
.riot/requirements/114bad8.txt                                          @DataDog/apm-python
.riot/requirements/11f2bd0.txt                                          @DataDog/apm-python
.riot/requirements/11fd02a.txt                                          @DataDog/apm-python
.riot/requirements/1261ed3.txt                                          @DataDog/apm-python
.riot/requirements/1304e20.txt                                          @DataDog/apm-python
.riot/requirements/1332b9d.txt                                          @DataDog/apm-python
.riot/requirements/13658ae.txt                                          @DataDog/apm-python
.riot/requirements/136fddd.txt                                          @DataDog/apm-python
.riot/requirements/1374394.txt                                          @DataDog/apm-python
.riot/requirements/1381214.txt                                          @DataDog/apm-python
.riot/requirements/13ae267.txt                                          @DataDog/apm-python
.riot/requirements/141bfd1.txt                                          @DataDog/apm-python
.riot/requirements/141f7eb.txt                                          @DataDog/apm-python
.riot/requirements/1463930.txt                                          @DataDog/apm-python
.riot/requirements/14be2f6.txt                                          @DataDog/apm-python
.riot/requirements/14d7e8a.txt                                          @DataDog/apm-python
.riot/requirements/14f1594.txt                                          @DataDog/apm-python
.riot/requirements/152e97f.txt                                          @DataDog/apm-python
.riot/requirements/1584f8c.txt                                          @DataDog/apm-python
.riot/requirements/164c3ce.txt                                          @DataDog/apm-python
.riot/requirements/167b853.txt                                          @DataDog/apm-python
.riot/requirements/16acf84.txt                                          @DataDog/apm-python
.riot/requirements/16cc321.txt                                          @DataDog/apm-python
.riot/requirements/16d2d1f.txt                                          @DataDog/apm-python
.riot/requirements/16de9c4.txt                                          @DataDog/apm-python
.riot/requirements/178f7d5.txt                                          @DataDog/apm-python
.riot/requirements/17d40ef.txt                                          @DataDog/apm-python
.riot/requirements/1819cb6.txt                                          @DataDog/apm-python
.riot/requirements/188244e.txt                                          @DataDog/apm-python
.riot/requirements/18c6e70.txt                                          @DataDog/apm-python
.riot/requirements/18e9526.txt                                          @DataDog/apm-python
.riot/requirements/192c7c0.txt                                          @DataDog/apm-python
.riot/requirements/19bbf6d.txt                                          @DataDog/apm-python
.riot/requirements/1a485c9.txt                                          @DataDog/apm-python
.riot/requirements/1a508dc.txt                                          @DataDog/apm-python
.riot/requirements/1acabe0.txt                                          @DataDog/apm-python
.riot/requirements/1ada88e.txt                                          @DataDog/apm-python
.riot/requirements/1aed5dc.txt                                          @DataDog/apm-python
.riot/requirements/1b86c06.txt                                          @DataDog/apm-python
.riot/requirements/1b8d922.txt                                          @DataDog/apm-python
.riot/requirements/1ba390a.txt                                          @DataDog/apm-python
.riot/requirements/1bf4d76.txt                                          @DataDog/apm-python
.riot/requirements/1c22cf9.txt                                          @DataDog/apm-python
.riot/requirements/1cb554e.txt                                          @DataDog/apm-python
.riot/requirements/1ce0711.txt                                          @DataDog/apm-python
.riot/requirements/1ce93b3.txt                                          @DataDog/apm-python
.riot/requirements/1d74d67.txt                                          @DataDog/apm-python
.riot/requirements/1d8a93c.txt                                          @DataDog/apm-python
.riot/requirements/1dd5678.txt                                          @DataDog/apm-python
.riot/requirements/1e19c17.txt                                          @DataDog/apm-python
.riot/requirements/1e4bb51.txt                                          @DataDog/apm-python
.riot/requirements/1e4dfe1.txt                                          @DataDog/apm-python
.riot/requirements/1e659c4.txt                                          @DataDog/apm-python
.riot/requirements/1e70094.txt                                          @DataDog/apm-python
.riot/requirements/1ebb239.txt                                          @DataDog/apm-python
.riot/requirements/1ec9462.txt                                          @DataDog/apm-python
.riot/requirements/1f3b209.txt                                          @DataDog/apm-python
.riot/requirements/1fa3005.txt                                          @DataDog/apm-python
.riot/requirements/1fc9ecc.txt                                          @DataDog/apm-python
.riot/requirements/1fe8dd2.txt                                          @DataDog/apm-python
.riot/requirements/248da41.txt                                          @DataDog/apm-python
.riot/requirements/2538ed0.txt                                          @DataDog/apm-python
.riot/requirements/2581b3a.txt                                          @DataDog/apm-python
.riot/requirements/2644218.txt                                          @DataDog/apm-python
.riot/requirements/27d0ff8.txt                                          @DataDog/apm-python
.riot/requirements/27e3d7b.txt                                          @DataDog/apm-python
.riot/requirements/2d6c3d0.txt                                          @DataDog/apm-python
.riot/requirements/2dd0811.txt                                          @DataDog/apm-python
.riot/requirements/3ab519c.txt                                          @DataDog/apm-python
.riot/requirements/3b804dc.txt                                          @DataDog/apm-python
.riot/requirements/3c3f295.txt                                          @DataDog/apm-python
.riot/requirements/3dd53da.txt                                          @DataDog/apm-python
.riot/requirements/3f1be84.txt                                          @DataDog/apm-python
.riot/requirements/44eeaa9.txt                                          @DataDog/apm-python
.riot/requirements/4fd1520.txt                                          @DataDog/apm-python
.riot/requirements/5b922fc.txt                                          @DataDog/apm-python
.riot/requirements/6cf373b.txt                                          @DataDog/apm-python
.riot/requirements/70e034f.txt                                          @DataDog/apm-python
.riot/requirements/74ccb83.txt                                          @DataDog/apm-python
.riot/requirements/788c304.txt                                          @DataDog/apm-python
.riot/requirements/7a40e08.txt                                          @DataDog/apm-python
.riot/requirements/8ce955f.txt                                          @DataDog/apm-python
.riot/requirements/91fe586.txt                                          @DataDog/apm-python
.riot/requirements/9a07d4a.txt                                          @DataDog/apm-python
.riot/requirements/9a5c0d9.txt                                          @DataDog/apm-python
.riot/requirements/a0cc2a4.txt                                          @DataDog/apm-python
.riot/requirements/a9f396a.txt                                          @DataDog/apm-python
.riot/requirements/ae8bd25.txt                                          @DataDog/apm-python
.riot/requirements/b29075f.txt                                          @DataDog/apm-python
.riot/requirements/b403d9d.txt                                          @DataDog/apm-python
.riot/requirements/bc64f49.txt                                          @DataDog/apm-python
.riot/requirements/bc7a1f4.txt                                          @DataDog/apm-python
.riot/requirements/bcbec2a.txt                                          @DataDog/apm-python
.riot/requirements/bebdd41.txt                                          @DataDog/apm-python
.riot/requirements/c1351c9.txt                                          @DataDog/apm-python
.riot/requirements/c4d4455.txt                                          @DataDog/apm-python
.riot/requirements/c77bbb6.txt                                          @DataDog/apm-python
.riot/requirements/c8b476b.txt                                          @DataDog/apm-python
.riot/requirements/d5098dd.txt                                          @DataDog/apm-python
.riot/requirements/d7dfbc2.txt                                          @DataDog/apm-python
.riot/requirements/d81ad99.txt                                          @DataDog/apm-python
.riot/requirements/db78045.txt                                          @DataDog/apm-python
.riot/requirements/dbc6a48.txt                                          @DataDog/apm-python
.riot/requirements/dbeb1d7.txt                                          @DataDog/apm-python
.riot/requirements/ddd8721.txt                                          @DataDog/apm-python
.riot/requirements/dedea98.txt                                          @DataDog/apm-python
.riot/requirements/df7a937.txt                                          @DataDog/apm-python
.riot/requirements/e06abee.txt                                          @DataDog/apm-python
.riot/requirements/e20152c.txt                                          @DataDog/apm-python
.riot/requirements/e2bf559.txt                                          @DataDog/apm-python
.riot/requirements/ee48b16.txt                                          @DataDog/apm-python
.riot/requirements/f20c964.txt                                          @DataDog/apm-python
.riot/requirements/f339e99.txt                                          @DataDog/apm-python
.riot/requirements/f33b994.txt                                          @DataDog/apm-python
.riot/requirements/f46a802.txt                                          @DataDog/apm-python
.riot/requirements/f4fafb3.txt                                          @DataDog/apm-python
.riot/requirements/fbee8ab.txt                                          @DataDog/apm-python
releasenotes/notes/threethirteen-d40d659d8939fe5e.yaml                  @DataDog/apm-python
.github/workflows/build_deploy.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/generate-package-versions.yml                         @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/requirements-locks.yml                                @DataDog/python-guild @DataDog/apm-core-python
.gitlab/download-dependency-wheels.sh                                   @DataDog/python-guild @DataDog/apm-core-python
.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
.gitlab/testrunner.yml                                                  @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_iast/_taint_tracking/__init__.py                        @DataDog/asm-python
ddtrace/debugging/_expressions.py                                       @DataDog/debugger-python
ddtrace/internal/_threads.cpp                                           @DataDog/apm-core-python
ddtrace/internal/injection.py                                           @DataDog/debugger-python @DataDog/apm-core-python
ddtrace/internal/wrapping/__init__.py                                   @DataDog/apm-core-python
ddtrace/internal/wrapping/context.py                                    @DataDog/apm-core-python
ddtrace/profiling/collector/stack.pyx                                   @DataDog/profiling-python
docker-compose.yml                                                      @DataDog/apm-core-python
docker/.python-version                                                  @DataDog/apm-core-python
docker/Dockerfile                                                       @DataDog/apm-core-python
docs/versioning.rst                                                     @DataDog/python-guild
hatch.toml                                                              @DataDog/python-guild
lib-injection/dl_wheels.py                                              @DataDog/apm-core-python
lib-injection/sources/sitecustomize.py                                  @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
setup.py                                                                @DataDog/python-guild
src/core/Cargo.lock                                                     @DataDog/apm-core-python
src/core/Cargo.toml                                                     @DataDog/apm-core-python
tests/contrib/futures/test_propagation.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/internal/crashtracker/test_crashtracker.py                        @DataDog/apm-core-python
tests/internal/symbol_db/test_symbols.py                                @DataDog/debugger-python
tests/internal/test_forksafe.py                                         @DataDog/apm-core-python
tests/internal/test_injection.py                                        @DataDog/debugger-python @DataDog/apm-core-python
tests/internal/test_wrapping.py                                         @DataDog/debugger-python @DataDog/apm-core-python
.riot/requirements/1df4764.txt                                          @DataDog/apm-python
.riot/requirements/4132bce.txt                                          @DataDog/apm-python
.riot/requirements/7bbf828.txt                                          @DataDog/apm-python

pr-commenter · 2024-09-26T14:48:56Z

Benchmarks

Benchmark execution time: 2024-12-18 16:03:46

Comparing candidate commit ff569a5 in PR branch brettlangdon/3.13 with baseline commit a7e9404 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

datadog-dd-trace-py-rkomorn · 2024-10-07T16:26:06Z

Datadog Report

Branch report: brettlangdon/3.13
Commit report: 7be0e66
Test service: dd-trace-py

✅ 0 Failed, 167 Passed, 1301 Skipped, 3m 0.16s Total duration (33m 34.63s time saved)

comment in docker-compose for local dev update riot locks for 3.13 limit riot envs that do not build with 3.13

emmettbutler · 2024-10-08T13:00:33Z

This is blocked by MatthieuDartiailh/bytecode#146

ddtrace/debugging/_function/store.py

erikayasuda

Just some NB questions, otherwise LGTM.

I think we need to add a 3.13 image in magic mirror before merging this? Looks like the 3.13 download job is failing

ddtrace/internal/injection.py

ddtrace/internal/wrapping/__init__.py

releasenotes/notes/threethirteen-d40d659d8939fe5e.yaml

Co-authored-by: erikayasuda <[email protected]>

sanchda

Looks good from profiling

ddtrace/profiling/collector/stack.pyx

setup.py

tests/internal/crashtracker/test_crashtracker.py

ddtrace/internal/injection.py

ddtrace/internal/_threads.cpp

P403n1x87

A few nits, otherwise LGTM

Co-authored-by: Gabriele N. Tornetta <[email protected]>

ci: test with Python 3.13

2e8b7ad

brettlangdon force-pushed the brettlangdon/3.13 branch from 3d2d76b to 2e8b7ad Compare September 26, 2024 14:15

emmettbutler added 4 commits October 7, 2024 11:00

handle changed API in python 3.13

d6a9e48

set build_core arg when compiling appsec/_iast/_stacktrace.c

9a4b0a2

no stack_v2 on 3.13 because it doesnt compile

79f5048

upgrade pyo3 for py3.13 support

f9dddb8

emmettbutler added 2 commits October 7, 2024 14:27

change include for 3.13

77dec79

update dockerfile

6c24c8e

comment in docker-compose for local dev update riot locks for 3.13 limit riot envs that do not build with 3.13

P403n1x87 and others added 4 commits October 28, 2024 16:51

update bytecode dependency

d65c2e1

Merge remote-tracking branch 'origin/main' into brettlangdon/3.13

291fa65

add support to the debugger

ae5b170

Merge branch 'main' into brettlangdon/3.13

a73fe2b

datadog-datadog-prod-us1 bot reviewed Dec 3, 2024

View reviewed changes

ddtrace/debugging/_function/store.py Outdated Show resolved Hide resolved

brettlangdon closed this Dec 4, 2024

emmettbutler reopened this Dec 9, 2024

Merge branch 'main' into brettlangdon/3.13

64647ca

emmettbutler self-assigned this Dec 9, 2024

emmettbutler added 9 commits December 9, 2024 08:11

depend on legacy cgi

9ffe7b3

update from dev version in gitlab

e42adc6

missed a spot

5606d86

missed a spot

8dee3e5

recert some Dockerfile changes

6b8c64a

fix dockerfile for bookworm

ae31e7d

typo

ffa5852

real version

96f7c7f

update sha

631e957

emmettbutler and others added 4 commits December 16, 2024 07:13

undo

369133c

undo

b1e186d

Merge branch 'main' into brettlangdon/3.13

96d8ae3

skip failing tests

4a66049

erikayasuda approved these changes Dec 16, 2024

View reviewed changes

ddtrace/internal/injection.py Outdated Show resolved Hide resolved

ddtrace/internal/wrapping/__init__.py Show resolved Hide resolved

releasenotes/notes/threethirteen-d40d659d8939fe5e.yaml Outdated Show resolved Hide resolved

emmettbutler and others added 2 commits December 16, 2024 14:02

Update releasenotes/notes/threethirteen-d40d659d8939fe5e.yaml

d78c403

Co-authored-by: erikayasuda <[email protected]>

Merge branch 'main' into brettlangdon/3.13

a7f69c0

emmettbutler approved these changes Dec 16, 2024

View reviewed changes

emmettbutler requested a review from sanchda December 16, 2024 22:14

sanchda approved these changes Dec 16, 2024

View reviewed changes

ddtrace/profiling/collector/stack.pyx Show resolved Hide resolved

setup.py Show resolved Hide resolved

tests/internal/crashtracker/test_crashtracker.py Show resolved Hide resolved

brettlangdon and others added 10 commits December 17, 2024 08:31

Merge branch 'main' into brettlangdon/3.13

56b1d0e

upgrade cibuildwheel and build on 3.13

d9b6a4e

no 313 windows builds for now

4015862

minimum osx update

3db58e6

downgrade

42fb931

nope

dfce6eb

try setting recommended envvar here

ed494f7

musllinux_1_1 -> musllinux_1_2

66deb95

Merge branch 'main' into brettlangdon/3.13

4211cba

remove skips

a4cf8aa

P403n1x87 reviewed Dec 18, 2024

View reviewed changes

ddtrace/internal/injection.py Outdated Show resolved Hide resolved

P403n1x87 reviewed Dec 18, 2024

View reviewed changes

ddtrace/internal/_threads.cpp Outdated Show resolved Hide resolved

P403n1x87 approved these changes Dec 18, 2024

View reviewed changes

emmettbutler and others added 4 commits December 18, 2024 05:36

Update ddtrace/internal/injection.py

82df9bb

Co-authored-by: Gabriele N. Tornetta <[email protected]>

Update ddtrace/internal/_threads.cpp

6aa76d8

Co-authored-by: Gabriele N. Tornetta <[email protected]>

Merge branch 'main' into brettlangdon/3.13

3495a2f

Merge branch 'main' into brettlangdon/3.13

ff569a5

emmettbutler disabled auto-merge December 18, 2024 16:23

emmettbutler merged commit c7b888d into main Dec 18, 2024
599 of 600 checks passed

emmettbutler deleted the brettlangdon/3.13 branch December 18, 2024 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: test with Python 3.13 #10821

ci: test with Python 3.13 #10821

brettlangdon commented Sep 26, 2024 •

edited by erikayasuda

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

pr-commenter bot commented Sep 26, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Oct 7, 2024 •

edited

Loading

emmettbutler commented Oct 8, 2024

erikayasuda left a comment

sanchda left a comment

P403n1x87 left a comment

ci: test with Python 3.13 #10821

ci: test with Python 3.13 #10821

Conversation

brettlangdon commented Sep 26, 2024 • edited by erikayasuda Loading

Checklist

Reviewer Checklist

github-actions bot commented Sep 26, 2024 • edited Loading

pr-commenter bot commented Sep 26, 2024 • edited Loading

Benchmarks

datadog-dd-trace-py-rkomorn bot commented Oct 7, 2024 • edited Loading

Datadog Report

emmettbutler commented Oct 8, 2024

erikayasuda left a comment

Choose a reason for hiding this comment

sanchda left a comment

Choose a reason for hiding this comment

P403n1x87 left a comment

Choose a reason for hiding this comment

brettlangdon commented Sep 26, 2024 •

edited by erikayasuda

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

pr-commenter bot commented Sep 26, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Oct 7, 2024 •

edited

Loading