-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure_functions): add azure functions integration #11474
feat(azure_functions): add azure functions integration #11474
Conversation
|
7c49099
to
b9e3a70
Compare
b9e3a70
to
10a50a1
Compare
BenchmarksBenchmark execution time: 2024-12-18 02:05:36 Comparing candidate commit bf3baa9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 378 metrics, 2 unstable metrics. |
1fc8c18
to
12969c6
Compare
12969c6
to
fb17586
Compare
fb17586
to
cdecdaa
Compare
ca0a772
to
547dc32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! There are a few areas where this change could be more aligned with our common practice in this repo.
Datadog ReportBranch report: ✅ 0 Failed, 697 Passed, 771 Skipped, 5m 11.71s Total duration (28m 17.54s time saved) |
…gration tests" This reverts commit 6e7563c.
.../snapshots/tests.contrib.azure_functions.test_azure_functions_snapshot.test_http_get_ok.json
Outdated
Show resolved
Hide resolved
...apshots/tests.contrib.azure_functions.test_azure_functions_snapshot.test_http_get_error.json
Show resolved
Hide resolved
@duncanpharvey Can you please provide instructions for running these tests locally? When I try running with |
Sure!
Sometimes on the initial run it times out when starting up the Azure Function. If you add a delay to
12/13 update: I committed this retry delay so it doesn't trip up someone running these tests locally in the future. It shouldn't affect how long the tests take to run in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, we should try to detect/infer a user's expected service name for the function
This PR adds an integration for tracing the azure-functions package.
Additional Notes:
3.7
to3.11
(no3.12
support at the moment)mariadb
install was broken in the testrunner imagelinux/amd64
architectureChecklist
Reviewer Checklist