Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove expired until from django snapshot test #11763

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Dec 17, 2024

The until timestamp in the flaky decorator on Django snapshots has been expired since Jan 2024, which was uncovered by #11274

As seen in this failed run: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/742978251, if we remove it, the current failure is on:

meta mismatch on '_dd.base_service': got 'tests.contrib.django' which does not match expected ''.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/django/test_django_snapshots.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_middleware_trace_partial_based_view.json  @DataDog/apm-python

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 17, 2024
@wantsui wantsui changed the title chore: remove expired until_then flaky decorator on django snapshot test chore: remove expired until from django snapshot test Dec 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024

Benchmarks

Benchmark execution time: 2024-12-19 20:49:47

Comparing candidate commit 455c395 in PR branch wantsui/remove-flaky-on-django-snapshot with baseline commit e8aab65 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@wantsui wantsui marked this pull request as ready for review December 18, 2024 20:18
@wantsui wantsui requested review from a team as code owners December 18, 2024 20:18
@emmettbutler emmettbutler enabled auto-merge (squash) December 19, 2024 17:59
@emmettbutler emmettbutler merged commit 494c039 into main Dec 19, 2024
145 of 147 checks passed
@emmettbutler emmettbutler deleted the wantsui/remove-flaky-on-django-snapshot branch December 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants