-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracer): remove asm properties from the tracer class #11791
Conversation
|
BenchmarksBenchmark execution time: 2025-01-02 18:52:03 Comparing candidate commit 5579309 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
a2713a3
to
6cd501f
Compare
6cd501f
to
4bb4c5e
Compare
9c66728
to
bdba284
Compare
bdba284
to
c6af5ea
Compare
LGTM! great job Munir! 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit and a few clarifying questions. Otherwise LGTM from the core/LP side
Description
Removes the following tracer fields and replaces all usages with the corresponding
asm_config
:Next steps:
ddtrace/_trace/tracer.py
.Motivation
Checklist
Reviewer Checklist