Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vendored contextvars module #11811

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Dec 19, 2024

contextvars was added in version 3.7.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested review from a team as code owners December 19, 2024 22:40
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/compat.py                                              @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/coverage/code.py                                       @DataDog/apm-core-python @datadog/ci-app-libraries
ddtrace/vendor/__init__.py                                              @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2025-01-13 15:42:09

Comparing candidate commit ac0e9b0 in PR branch taegyunkim/remove-vendor-contextvars with baseline commit 30e3b76 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a proper review once tests are passing

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 8, 2025

Datadog Report

Branch report: taegyunkim/remove-vendor-contextvars
Commit report: ac0e9b0
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 23.21s Total duration (35m 39.34s time saved)

@taegyunkim taegyunkim requested a review from a team as a code owner January 8, 2025 21:08
@taegyunkim taegyunkim requested a review from gnufede January 8, 2025 21:08
@taegyunkim
Copy link
Contributor Author

@emmettbutler ready for a review, can you take a look?

@taegyunkim taegyunkim requested review from vitor-de-araujo and removed request for tonyredondo January 8, 2025 22:28
taegyunkim added a commit that referenced this pull request Jan 10, 2025
@taegyunkim taegyunkim enabled auto-merge (squash) January 13, 2025 15:04
@taegyunkim taegyunkim merged commit 54fe875 into main Jan 13, 2025
672 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/remove-vendor-contextvars branch January 13, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants