Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): migrate test packages to gitlab #11827

Merged
merged 15 commits into from
Jan 13, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Dec 23, 2024

Tests packages are failing in main on CircleCi due to timeout. We’re not sure the root cause because the CI has been broken for over 7 days, until #11807 reverted the changes. Making it nearly impossible to pinpoint where the issue started in CircleCI. So, W've decided it's time to migrate this to GitLab

CAVEAT: test_packages will only run on the main branch. Therefore, these tests haven't been executed in this PR, but the previous commit included a configuration to run them here to validate functionality https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/748795172

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Dec 23, 2024
Copy link
Contributor

github-actions bot commented Dec 23, 2024

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 23, 2024

Benchmarks

Benchmark execution time: 2025-01-13 08:41:19

Comparing candidate commit 12bf4e1 in PR branch avara1986/migrate_test_packages_to_gitlab with baseline commit d0b151a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 24, 2024

Datadog Report

Branch report: avara1986/migrate_test_packages_to_gitlab
Commit report: 12bf4e1
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 1.94s Total duration (35m 56.41s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.75%. Comparing base (e474267) to head (1cf265b).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11827      +/-   ##
==========================================
- Coverage   14.16%    5.75%   -8.42%     
==========================================
  Files        1550     1541       -9     
  Lines      134259   131556    -2703     
==========================================
- Hits        19019     7566   -11453     
- Misses     115240   123990    +8750     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avara1986 avara1986 marked this pull request as ready for review December 24, 2024 11:03
@avara1986 avara1986 requested review from a team as code owners December 24, 2024 11:03
Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating this off CircleCI! 🎉

tests/appsec/suitespec.yml Show resolved Hide resolved
@avara1986 avara1986 merged commit 0905049 into main Jan 13, 2025
680 checks passed
@avara1986 avara1986 deleted the avara1986/migrate_test_packages_to_gitlab branch January 13, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants