Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): refactor out ragas base evaluator #11846

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Conversation

lievan
Copy link
Contributor

@lievan lievan commented Jan 2, 2025

Creates a RagasBaseEvaluator class that ragas evaluators can share. This is a split-out version of this PR that has incorporated changes based on the first round of comments from @Yun-Kim and @Kyle-Verhoog

This class contains shared logic for:

  • checking ragas dependencies are present, and throwing otherwise
  • submit_and_evaluate function, which generally takes a span event, calls evaluate to generate a score, and then submits an evaluation
  • extracting out question, contexts, and answer from an LLM span

Misc changes

  • rename tests to specify they are faithfulness-specific tests
  • throw when we parse an unsupported evaluator instead of logging a warning

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 2, 2025

CODEOWNERS have been resolved as:

ddtrace/llmobs/_evaluators/ragas/base.py                                @DataDog/ml-observability
ddtrace/llmobs/_evaluators/ragas/faithfulness.py                        @DataDog/ml-observability
ddtrace/llmobs/_evaluators/runner.py                                    @DataDog/ml-observability
tests/llmobs/_utils.py                                                  @DataDog/ml-observability
tests/llmobs/test_llmobs_evaluator_runner.py                            @DataDog/ml-observability
tests/llmobs/llmobs_cassettes/tests.llmobs.test_llmobs_ragas_evaluators.emits_traces_and_evaluations_on_exit.yaml  @DataDog/ml-observability
tests/llmobs/llmobs_cassettes/tests.llmobs.test_llmobs_ragas_evaluators.test_ragas_faithfulness_emits_traces.yaml  @DataDog/ml-observability
tests/llmobs/llmobs_cassettes/tests.llmobs.test_llmobs_ragas_evaluators.test_ragas_faithfulness_submits_evaluation.yaml  @DataDog/ml-observability
tests/llmobs/llmobs_cassettes/tests.llmobs.test_llmobs_ragas_evaluators.test_ragas_faithfulness_submits_evaluation_on_span_with_custom_keys.yaml  @DataDog/ml-observability
tests/llmobs/llmobs_cassettes/tests.llmobs.test_llmobs_ragas_evaluators.test_ragas_faithfulness_submits_evaluation_on_span_with_question_in_messages.yaml  @DataDog/ml-observability
tests/llmobs/test_llmobs_ragas_evaluators.py                            @DataDog/ml-observability

@lievan lievan marked this pull request as ready for review January 2, 2025 15:06
@lievan lievan requested a review from a team as a code owner January 2, 2025 15:06
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 2, 2025

Datadog Report

Branch report: evan.li/ragas-base
Commit report: 7d7b245
Test service: dd-trace-py

✅ 0 Failed, 289 Passed, 1179 Skipped, 7m 22.32s Total duration (29m 15.6s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 2, 2025

Benchmarks

Benchmark execution time: 2025-01-09 21:02:05

Comparing candidate commit 967bddd in PR branch evan.li/ragas-base with baseline commit 04ee68f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

ddtrace/llmobs/_evaluators/ragas/base.py Outdated Show resolved Hide resolved
ddtrace/llmobs/_evaluators/ragas/base.py Outdated Show resolved Hide resolved
ddtrace/llmobs/_evaluators/ragas/base.py Show resolved Hide resolved
ddtrace/llmobs/_evaluators/ragas/base.py Outdated Show resolved Hide resolved
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion for the telemetry then good to go

ddtrace/llmobs/_evaluators/ragas/base.py Outdated Show resolved Hide resolved
ddtrace/llmobs/_evaluators/ragas/base.py Show resolved Hide resolved
ddtrace/llmobs/_evaluators/ragas/base.py Outdated Show resolved Hide resolved
@lievan lievan added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 9, 2025
@lievan lievan merged commit 5e68823 into main Jan 10, 2025
265 checks passed
@lievan lievan deleted the evan.li/ragas-base branch January 10, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants