-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): refactor out ragas base evaluator #11846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Datadog ReportBranch report: ✅ 0 Failed, 289 Passed, 1179 Skipped, 7m 22.32s Total duration (29m 15.6s time saved) |
lievan
commented
Jan 2, 2025
Yun-Kim
approved these changes
Jan 7, 2025
Kyle-Verhoog
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one suggestion for the telemetry then good to go
Kyle-Verhoog
approved these changes
Jan 9, 2025
lievan
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a
RagasBaseEvaluator
class that ragas evaluators can share. This is a split-out version of this PR that has incorporated changes based on the first round of comments from @Yun-Kim and @Kyle-VerhoogThis class contains shared logic for:
submit_and_evaluate
function, which generally takes a span event, calls evaluate to generate a score, and then submits an evaluationMisc changes
Checklist
Reviewer Checklist