Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cos): include module and function on exit #11882

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jan 9, 2025

We use the result of a cached utility function to retrieve the function object referencing a given code object. This allows us to retrieve the module and the fully qualified function name for the frames on the stack of the exit span.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Jan 9, 2025
@P403n1x87 P403n1x87 requested review from a team as code owners January 9, 2025 11:08
@P403n1x87 P403n1x87 requested a review from emmettbutler January 9, 2025 11:08
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CODEOWNERS have been resolved as:

ddtrace/debugging/_function/discovery.py                                @DataDog/debugger-python
ddtrace/debugging/_origin/span.py                                       @DataDog/debugger-python
ddtrace/internal/utils/inspection.py                                    @DataDog/apm-core-python
tests/debugging/conftest.py                                             @DataDog/debugger-python
tests/debugging/test_debugger.py                                        @DataDog/debugger-python
tests/debugging/test_debugger_span_decoration.py                        @DataDog/debugger-python

@P403n1x87 P403n1x87 enabled auto-merge (squash) January 9, 2025 11:09
We use the result of a cached utility function to retrieve the function
object referencing a given code object. This allows us to retrieve the
module and the fully qualified function name for the frames on the stack
of the exit span.
@P403n1x87 P403n1x87 force-pushed the chore/cos-module-function-on-exit branch from 1f5a399 to 616c160 Compare January 9, 2025 11:09
@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-21 11:24:15

Comparing candidate commit 503e775 in PR branch chore/cos-module-function-on-exit with baseline commit 0111544 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 20, 2025

Datadog Report

Branch report: chore/cos-module-function-on-exit
Commit report: 503e775
Test service: dd-trace-py

✅ 0 Failed, 1598 Passed, 0 Skipped, 28m 49.27s Total duration (13m 10.41s time saved)

@P403n1x87 P403n1x87 merged commit f198341 into main Jan 21, 2025
689 of 691 checks passed
@P403n1x87 P403n1x87 deleted the chore/cos-module-function-on-exit branch January 21, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants