Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(er): include nonlocals in snapshots [backport 2.18] #11901

Open
wants to merge 1 commit into
base: 2.18
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Backport d7927e6 from #11894 to 2.18.

We include nonlocal variables in snapshots to provide for better visibility into exception occurrences.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We include nonlocal variables in snapshots to provide for better
visibility into exception occurrences.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit d7927e6)
@github-actions github-actions bot requested review from a team as code owners January 10, 2025 18:46
@github-actions github-actions bot added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jan 10, 2025
@github-actions github-actions bot requested review from juanjux and wconti27 January 10, 2025 18:46
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-11894-to-2.18
Commit report: 71fd251
Test service: dd-trace-py

✅ 0 Failed, 5 Passed, 1463 Skipped, 54.85s Total duration (35m 35.47s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 19:29:56

Comparing candidate commit 71fd251 in PR branch backport-11894-to-2.18 with baseline commit 0a56ee9 in branch 2.18.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@P403n1x87 P403n1x87 closed this Jan 13, 2025
@P403n1x87 P403n1x87 reopened this Jan 13, 2025
@P403n1x87 P403n1x87 enabled auto-merge (squash) January 13, 2025 10:57
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/fix-er-include-nonlocals-bbeecfbbbde35496.yaml       @DataDog/apm-python
ddtrace/debugging/_safety.py                                            @DataDog/debugger-python
tests/debugging/exception/test_replay.py                                @DataDog/debugger-python
tests/debugging/test_safety.py                                          @DataDog/debugger-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant