Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct default value for DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED config #11906

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

frrahat
Copy link

@frrahat frrahat commented Jan 13, 2025

addresses #11905

As per documentation default value for DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED is False:

DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED:
type: Boolean
default: False

But in code it is being passed as True:

self._128_bit_trace_id_enabled = _get_config("DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED", True, asbool)

I think it was introduced by this: #7181 and True as default is the expected here. So updated the documentation accordingly in this PR.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@frrahat frrahat requested a review from a team as a code owner January 13, 2025 08:49
@frrahat frrahat requested a review from sanchda January 13, 2025 08:49
@frrahat frrahat force-pushed the fix-config-128-bit-traceid-generation branch from 8bbecc0 to d349012 Compare January 13, 2025 10:14
@emmettbutler emmettbutler enabled auto-merge (squash) January 13, 2025 14:40
@frrahat
Copy link
Author

frrahat commented Jan 17, 2025

I think we need to add "changelog/no-changelog" label, right? cc: @sanchda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants