Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(asm): appsec and iast with product plugin interface #12025

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jan 22, 2025

Migrate appsec and iast code to product plugin interface

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede changed the title refactor preload to use appsec and iast with product interface refactor(asm): appsec and iast with product plugin interface Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/appsec/product.py                                      @DataDog/asm-python
ddtrace/internal/iast/product.py                                        @DataDog/asm-python
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_remoteconfiguration.py                                  @DataDog/asm-python
ddtrace/bootstrap/preload.py                                            @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 22, 2025

Datadog Report

Branch report: gnufede/asm-product-plugin-interface
Commit report: 1da244d
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 37.14s Total duration (35m 35.04s time saved)

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 22, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-23 13:46:11

Comparing candidate commit c3eccd9 in PR branch gnufede/asm-product-plugin-interface with baseline commit ff41c13 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

pyproject.toml Outdated Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 23, 2025

Datadog Report

Branch report: gnufede/asm-product-plugin-interface
Commit report: c3eccd9
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 36s Total duration (35m 37.19s time saved)

@gnufede gnufede marked this pull request as ready for review January 23, 2025 13:06
@gnufede gnufede requested review from a team as code owners January 23, 2025 13:06
@gnufede gnufede requested a review from P403n1x87 January 23, 2025 13:10
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 awesome, thanks!

@gnufede gnufede enabled auto-merge (squash) January 23, 2025 17:01
@gnufede gnufede merged commit 7669493 into main Jan 24, 2025
711 of 712 checks passed
@gnufede gnufede deleted the gnufede/asm-product-plugin-interface branch January 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants