chore(llmobs): [MLOB-1944] generalize helper for extracting token metrics #12026
+28
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the helper method used to extract token metrics from an APM span to be attached to an LLMObs span. Before, Anthropic, Bedrock, and Open AI had specific methods on each of their integration classes to accomplish this. Now, there is one
get_llmobs_metrics_tags
utils function adapted from the google-specificget_llmobs_metrics_tags_google
function that gets reused across these integrations as well as Vertex AI and Gemini. The Langchain integration was excluded from this change since its logic for extracting token metrics varies significantly compared to the other integrations.Testing
Anthropic
Running the code above produced this APM span and this LLM span with the following metrics:
Bedrock
Running the code above produced this APM span and this LLM span with the following metrics:
Gemini
Running the code above produced this APM span and this LLM span with the following metrics:
Open AI
Running the code above produced this APM span and this LLM span with the following metrics:
Vertex AI
Running the code above produced this APM span and this LLM span with the following metrics:
Checklist
Reviewer Checklist